Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Saturday, August 11, 2007 - 4:14 pm

Casey Schaufler <casey@schaufler-ca.com> writes:


I like the simplified part.


Do I miss something, or is there really no locking for the reader side
of the list? That looks dangerous. Of course a global lock for readers 
would be likely a scaling disaster. You could use RCU.

Or if you assume rules are changed only very infrequently it might
be more cache friendly to compile all the rules into a linear buffer
and then just replace the whole buffer atomically with a RCU
grace period on cahnges.

It doesn't look like it would scale to larger numbers of rules though.
Is that intended? Would caching of decisions fit into the design?

Also in general code style would need some improvements;
e.g. no externs in .c; no ../.. include hacks etc.
You also seem weak on the Documentation front.
Other than that it looks reasonably clean (haven't read all of it)

-Andi
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Smack: Simplified Mandatory Access Control Kernel, Casey Schaufler, (Sat Aug 11, 10:57 am)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Arjan van de Ven, (Sat Aug 11, 12:12 pm)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Casey Schaufler, (Sat Aug 11, 12:56 pm)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Andi Kleen, (Sat Aug 11, 4:14 pm)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Casey Schaufler, (Sun Aug 12, 10:48 am)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Casey Schaufler, (Sun Aug 12, 12:41 pm)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Casey Schaufler, (Sun Aug 12, 12:50 pm)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Valdis.Kletnieks, (Sun Aug 19, 2:12 pm)
Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel, Casey Schaufler, (Wed Aug 22, 11:47 am)