login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
August
»
11
Re: [PATCH] fix crash in sbp2_remove_device() when dma_set_mask() fails
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Stefan Richter
Subject:
Re: [PATCH] fix crash in sbp2_remove_device() when dma_set_mask() fails
Date: Saturday, August 11, 2007 - 2:45 am
On 6 Aug, Olaf Hering wrote:
quoted text
> --- a/drivers/ieee1394/sbp2.c > +++ b/drivers/ieee1394/sbp2.c > @@ -929,13 +929,14 @@ static void sbp2_remove_device(struct sb > if (!lu) > return; > > - hi = lu->hi; > - > if (lu->shost) { > scsi_remove_host(lu->shost); > scsi_host_put(lu->shost); > } > flush_scheduled_work(); > + hi = lu->hi; > + if (!hi) > + return;
We need to kfree lu here. Patch comes right away.
quoted text
> sbp2util_remove_command_orb_pool(lu); > > list_del(&lu->lu_list); > @@ -977,8 +978,7 @@ static void sbp2_remove_device(struct sb > > lu->ud->device.driver_data = NULL; > > - if (hi) > - module_put(hi->host->driver->owner); > + module_put(hi->host->driver->owner); > > kfree(lu); > }
-- Stefan Richter -=====-=-=== =--- -=-==
http://arcgraph.de/sr/
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] fix crash in sbp2_remove_device() when dma_set_mas ...
, Olaf Hering
, (Mon Aug 6, 5:20 am)
Re: [PATCH] fix crash in sbp2_remove_device() when dma_set ...
, Stefan Richter
, (Mon Aug 6, 4:10 pm)
Re: [PATCH] fix crash in sbp2_remove_device() when dma_set ...
, Stefan Richter
, (Sat Aug 11, 2:45 am)
[PATCH] ieee1394: sbp2: fix sbp2_remove_device for error cases
, Stefan Richter
, (Sat Aug 11, 2:51 am)
[PATCH] ieee1394: sbp2: fix unsafe iteration over list of ...
, Stefan Richter
, (Sat Aug 11, 2:52 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Mel Gorman
Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck
Re: [lm-sensors] Location for thermal drivers
David Woodhouse
Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B
Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra
Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head
:
Linux Kernel Mailing List
[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List
USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List
lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List
[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List
[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev
:
MERCEDES
Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller
Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller
Re: skb_segment() questions
Shan Wei
[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka
[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git
:
Nicolas Sebrecht
git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano
Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff
Re: [PATCH] GIT commit statistics.
Alexandre Julliard
[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett
[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc
:
Taisto Qvist XX
Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer
Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier
Re: jetway board sensors (Fintek F71805F)
admin
Drive a 2009 car from R799p/m
Antti Harri
Re: how to create a sha256 hash
Colocation donated by:
Syndicate