Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Friday, August 10, 2007 - 10:16 am

> In that code we could just do a test on valp (i.e. data in struct

Or you could pass the struct pointer and subtract the array start


Well I'd like you to not replace one pile of hard to clean up but easy to
locate crap by smearing other hard to fix in one go crap over the kernel.

I'll add it to my todo list. But in the meantime I still NAK the change.
I'll try and get a patch sorted but it'll be after the kernel summit for
sure.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Remove CTL_UNNUMBERED, Alexey Dobriyan, (Thu Jul 26, 9:45 am)
Re: [PATCH] Remove CTL_UNNUMBERED, Eric W. Biederman, (Thu Jul 26, 10:24 am)
Re: [PATCH] Remove CTL_UNNUMBERED, Alexey Dobriyan, (Fri Jul 27, 7:52 am)
[PATCH 2/2] sysctl: remove CTL_UNNUMBERED, Alexey Dobriyan, (Mon Aug 6, 5:45 am)
Re: [PATCH 2/2] sysctl: remove CTL_UNNUMBERED, Eric W. Biederman, (Thu Aug 9, 12:44 pm)
[PATCH 1/3] sysctl core: Stop using the unnecessary ctl_ta ..., Eric W. Biederman, (Thu Aug 9, 12:50 pm)
[PATCH 2/3] sysctl: Factor out sysctl_data., Eric W. Biederman, (Thu Aug 9, 12:52 pm)
[PATCH 3/3] sysctl: Error on bad sysctl tables, Eric W. Biederman, (Thu Aug 9, 1:09 pm)
[PATCH 01/10] sysctl: Update sysctl_check_table, Eric W. Biederman, (Thu Aug 9, 5:49 pm)
[PATCH 02/10] sysct mqueue: Remove the binary sysctl numbers, Eric W. Biederman, (Thu Aug 9, 5:51 pm)
[PATCH 04/10] sysctl: Fix neighbour table sysctls., Eric W. Biederman, (Thu Aug 9, 5:56 pm)
[PATCH 05/10] sysctl: ipv6 route flushing (kill binary path), Eric W. Biederman, (Thu Aug 9, 5:57 pm)
[PATCH 07/10] sysctl: x86_64 remove unnecessary binary paths., Eric W. Biederman, (Thu Aug 9, 5:59 pm)
[PATCH 08/10] sysctl: Remove broken cdrom binary sysctls, Eric W. Biederman, (Thu Aug 9, 6:01 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., YOSHIFUJI Hideaki / , (Thu Aug 9, 6:47 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., David Miller, (Thu Aug 9, 6:49 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., Andrew Morton, (Thu Aug 9, 6:55 pm)
Re: [PATCH 3/3] sysctl: Error on bad sysctl tables, YOSHIFUJI Hideaki / , (Thu Aug 9, 7:01 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., Eric W. Biederman, (Thu Aug 9, 7:12 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., YOSHIFUJI Hideaki / , (Thu Aug 9, 7:14 pm)
Re: [PATCH 3/3] sysctl: Error on bad sysctl tables, Eric W. Biederman, (Thu Aug 9, 7:15 pm)
Re: [PATCH 3/3] sysctl: Error on bad sysctl tables, Eric W. Biederman, (Thu Aug 9, 7:18 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., YOSHIFUJI Hideaki / , (Thu Aug 9, 7:22 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., Eric W. Biederman, (Thu Aug 9, 7:23 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., YOSHIFUJI Hideaki / , (Thu Aug 9, 7:29 pm)
Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls., Eric W. Biederman, (Thu Aug 9, 7:35 pm)
Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls, Eric W. Biederman, (Fri Aug 10, 8:55 am)
Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls, Alan Cox, (Fri Aug 10, 10:16 am)
Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls, Eric W. Biederman, (Fri Aug 10, 11:30 am)