Greetings & Salutations, The Coverity checker spotted two potential memory leaks in drivers/message/fusion/mptbase.c::mpt_attach(). There are two returns that may leak the storage allocated for 'ioc' (sizeof(MPT_ADAPTER) bytes). A simple fix would be to simply add two kfree() calls before the return statements, but a better fix (that this patch implements) is to reorder the code so that if we hit the first return condition we don't have to do the allocation at all and then just add a ...

On Wed, 1 Aug 2007 16:31:46 -0700 <useful thanks. But snipped> -

Hi, Currently scripts/ver_linux prints "Binutils" or other random information for the version number in the "binutils" output line on some distributions. This patch corrects that. When I initially submitted a patch to correct that, I was not aware that the output from "ld -v" could differ as much as it turned out it can, so my original fix turned out to not cover all bases. This patch works correctly with all the different "ld -v" output that people posted in replys to my first patch, so it...

Since the callers of futex_atomic_cmpxchg_inatomic() don't really seem prepared to deal with -ENOSYS (e.g. the handle_futex_death() infinite loop when it gets -ENOSYS), it seems better never to return -ENOSYS from this function at all. What if you just stick an #error in here in the SMP case? -

Looks like the same problem with spinlock unfairness we've seen elsewhere: it seems to be looping here? Or is everyone stuck just waiting for writeout? lock_timer_base(): for (;;) { tvec_base_t *prelock_base = timer->base; base = tbase_get_base(prelock_base); if (likely(base != NULL)) { spin_lock_irqsave(&base->lock, *flags); if (likely(prelock_base == timer->base)) ...

If we were totally rigurous about representing each device as a device node, your solution would be fine. But we don't. The clocksource model (/sys/devices/system/clocksource) is a better way to go. One sysfs file is used to enumerate the possible sources and another is used to read or set the current source. No new system calls; no new ioctls. -ch ch (at) murgatroid (dot) com ch (at) hpl (dot) hp (dot) com -

This patch demonstrates an extension field to the low-level marker functionality, and updates macros to accept this additional data. Index: linux-2.6.22-rc6-mm1/include/linux/marker.h =================================================================== --- linux-2.6.22-rc6-mm1.orig/include/linux/marker.h 2007-08-01 15:39:36.000000000 -0500 +++ linux-2.6.22-rc6-mm1/include/linux/marker.h 2007-08-01 15:39:37.000000000 -0500 @@ -31,10 +31,14 @@ const char *args; /* List of arguments litteraly tran...

Greg: For those of us who forget that when bits 21 and bit 31 in a hardware register exposed with debugfs, I should see 2149580800 when I cat it (vs 0x80200000), any objections to providing a hex output interface to the debugfs? Since the input side already takes decimal & hex, I don't think this is a big change: DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n"); struct dentry *debugfs_create_x16(const char *name, mode_t mode, ...

Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/arm/icside.c | 3 +- drivers/ide/ide-tape.c | 2 +- drivers/ide/pci/alim15x3.c | 2 +- drivers/ide/pci/cmd64x.c | 4 +- drivers/ide/pci/cs5520.c | 2 +- drivers/ide/pci/cs5535.c | 42 +++++++++++++----------------- drivers/ide/pci/it8213.c | 33 ++++++++++++----------- drivers/ide/pci/jmicron.c | 21 +++------------ drivers/ide/...

libata drivers can define a function (enable_pm) that will perform hardware specific actions to enable whatever power management policy the user set up from the scsi sysfs interface if the driver supports it. This power management policy will be activated after all disks have been enumerated and intialized. Drivers should also define disable_pm, which will turn off link power management, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi...

Hi, This is an updated series of ALPM patches. I moved all link power management stuff out of scsi sysfs and just use the shost_addr pointer in the host template to create the sysfs files. This provides the same interface as before, without requiring any scsi changes. I also fixed a bug in the handling of the interrupts for some devices (mostly ATAPI it seems) which will need some bits out of Serror cleared on power state changes, and I also modified the code slightly based on feedback from tejun....

From: Rafael J. Wysocki <rjw@sisk.pl> Measure the time of the freezing of tasks, even if it doesn't fail. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Acked-by: Pavel Machek <pavel@ucw.cz> --- kernel/power/process.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) Index: linux-2.6.23-rc1/kernel/power/process.c =================================================================== --- linux-2.6.23-rc1.orig/kernel/power/process.c 2007-07-31 23:00:43....

From: Rafael J. Wysocki <rjw@sisk.pl> Use the observation that try_to_freeze_tasks() need not loop while waiting for the freezing tasks to enter the refrigerator and make it use a wait queue. The idea is that after sending freeze requests to the tasks regarded as freezable try_to_freeze_tasks() can go to sleep and wait until at least one task enters the refrigerator.  The first task that does it wakes up try_to_freeze_tasks() and the procedure is repeated.  If the refrigerator is not ente...

From: Rafael J. Wysocki <rjw@sisk.pl> Increase the freezer's verbosity a bit, so that it's easier to read problem reports related to it. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Acked-by: Nigel Cunningham <nigel@nigel.suspend2.net> Acked-by: Pavel Machek <pavel@ucw.cz> --- kernel/power/process.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) Index: linux-2.6.23-rc1/kernel/power/process.c =================================================...

The following strange behavior can be observed: 1. large file is written 2. after 30 seconds, nr_dirty goes down by 1024 3. then for some time (< 30 sec) nothing happens (disk idle) 4. then nr_dirty again goes down by 1024 5. repeat from 3. until whole file is written So basically a 4Mbyte chunk of the file is written every 30 seconds. I'm quite sure this is not the intended behavior. The reason seems to be that __sync_single_inode() will move the partially written inode from s_io onto s_d...

I'm making an assumption that depmod is somehow to blame and have logged this as a kernel bug, -- Maurice Volaski, mvolaski@aecom.yu.edu Computing Support, Rose F. Kennedy Center Albert Einstein College of Medicine of Yeshiva University -

First, did you confirm this behavior? Can you please explain that? -- Maurice Volaski, mvolaski@aecom.yu.edu Computing Support, Rose F. Kennedy Center Albert Einstein College of Medicine of Yeshiva University -

On Wed, 1 Aug 2007 13:06:23 -0700 This isn't obviously doing the right thing for non-power-of-2 inputs. ilog2() rounds down... Please check that this, and all the other ilog2()s which have been added are doing the right thing if they can be presented with non-power-of-2 inputs? -

Guilt v0.27 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo: git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/guilt.git Alright, I'm trying to get back to the 2-week release schedule, so here's v0.27! There has been a number of changes in those two weeks, Out of the 20 commit...

Adrian, You said earlier you're looking at smaller allnoconfig kernels. One thing I noticed recently that realtime pi futexes are always enabled and that pulls in a lot of other code (like the plists) Userland needs to handle them not being available anyways for older kernels. Might be worth looking into turning that into a CONFIG. -Andi -

Hi sometimes user space program hangs forever. In old days i remeber there was unkillable dosemu. May be there are good how to. Some one can point to it? This is problem/solution isn't related to current kernel. This is question: what to do in this sitaution. Now i have eject(1) $ ps uax | grep eject root 12662 0.0 0.0 1528 560 ? D Jul31 0:00 eject root 12866 0.0 0.0 1532 560 pts/10 D Jul31 0:00 eject $ date Wed Aug 1 21:56:59 EEST 2007 Tha...

# cat /proc/kmsg > log & [1] 28058 # echo t >/proc/sysrq-trigger # sleep 3 # fg cat /proc/kmsg > log ^C it seems that i can't get full log. Not all proceses are listed on it. But some of "bad proceses i have". (full log: http://89.190.108.145/~rokas/tasks.txt) it seems that some are stoped on cdrom_transfer_packet_command, some on __mutex_lock_slowpath. I'm confused.. hald-addon-st D 000004E2 0 5826 1 17981 12866 (NOTLB) f55ebc34 c02c9717...

Fix missing numa_zonelist_order sysctl config Against 2.6.23-rc1-mm1. Found this testing Mel Gorman's patch for the issue with "policy_zone" and ZONE_MOVABLE. Misplaced #endif is hiding the numa_zonelist_order sysctl when !SECURITY. [But, maybe reordering the zonelists is not such a good idea when ZONE_MOVABLE is populated?] Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> kernel/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: Linux/kernel/s...

block2mtd: version $Revision: 1.30 $ block2mtd: mtd0: [d: /dev/sdc2] erase_size = 64KiB [65536] mtdsuper: module license 'unspecified' taints kernel. mtdsuper: Unknown symbol get_mtd_device mtdsuper: Unknown symbol put_mtd_device jffs2: Unknown symbol get_sb_mtd jffs2: Unknown symbol kill_mtd_super Signed-off-by: Rafał Bilski <rafalbilski@interia.pl> --- drivers/mtd/mtdsuper.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/mtdsuper.c b/drivers/m...

How about adding the attached text to the Documentation directory? I had to correct over the years to one or the other system call design problems. Other problems couldn't be corrected anymore and we have to live with them. Maybe spelling out the rules explicitly will help a bit. I've added a few rules I could think of right now. What should be added as well is a rule for 64-bit parameters on 32-bit platforms. I leave this to the s390 people who have the biggest restrictions when it comes to t...