debugfs helper for decimal challenged

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <gregkh@...>
Cc: <linux-kernel@...>, Mike Frysinger <vapier.adi@...>
Date: Wednesday, August 1, 2007 - 5:52 pm

Greg:

For those of us who forget that when bits 21 and bit 31 in a hardware 
register exposed with debugfs, I should see 2149580800 when I cat it (vs
0x80200000), any objections to providing a hex output interface to the 
debugfs?

Since the input side already takes decimal & hex, I don't think this is a big
change:

DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");

struct dentry *debugfs_create_x16(const char *name, mode_t mode,
                                  struct dentry *parent, u16 *value)
{
        return debugfs_create_file(name, mode, parent, value, &fops_x16);
}

DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");

struct dentry *debugfs_create_x32(const char *name, mode_t mode,
                                  struct dentry *parent, u32 *value)
{
        return debugfs_create_file(name, mode, parent, value, &fops_x32);
}

If this is OK - I will send a real patch.

-Robin
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
debugfs helper for decimal challenged, Robin Getz, (Wed Aug 1, 5:52 pm)
Re: debugfs helper for decimal challenged, Greg KH, (Wed Aug 1, 6:25 pm)
[PATCH] debugfs helper for decimal challenged, Robin Getz, (Wed Aug 1, 11:13 pm)
[PATCH] debugfs helper for decimal challenged, Robin Getz, (Thu Aug 2, 6:23 pm)
Re: [PATCH] debugfs helper for decimal challenged, Robin Getz, (Thu Aug 2, 6:20 pm)