On 7/31/07, Richard Knutsson <ricknu-0@student.ltu.se> wrote:
quoted text
> Mike Frysinger wrote:
> > On 7/27/07, Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> >> If there is a definite style or semantic preference that everyone should live
> >> with - does it make sense to put checks in checkpatch.pl to enforce it?
> >
> > checkpatch.pl does not have enough semantic knowledge to know if the
> > thing being tested is a pointer ... dont know if the sparse utility
> > would be able to pick it out as i'm not familiar with what level that
> > thing runs at
>
> Didn't he mean "x == NULL" > "!x"?

i'm sure i understand your meaning of ">" ... are you saying that "x
== NULL" is greater (preferred) to "!x" or are you saying that "x ==
NULL" should be changed to "!x" ?

i dont think the former case can be checked by checkpatch.pl, but the
latter certainly can ... but i'd be very skeptical you could get the
wider LKML audience to sign off one way or the other wrt to "x ==
NULL" vs "!x".  you can certainly get people to sign off on "x == 0"
being wrong when x is a pointer.
-mike
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/