Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member | KernelTrap

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Satyam Sharma <ssatyam@...>

To: Stephen Hemminger <shemminger@...>

Cc: Matt Mackall <mpm@...>, Linux Kernel Mailing List <linux-kernel@...>, Keiichi Kii <k-keiichi@...>, Netdev <netdev@...>, Joel Becker <joel.becker@...>, Andrew Morton <akpm@...>, David Miller <davem@...>

Subject: Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

Date: Saturday, July 7, 2007 - 4:08 am

Hi Stephen,

On Thu, 5 Jul 2007, Stephen Hemminger wrote:
quoted text> On Wed, 4 Jul 2007 08:56:42 -0500
> Matt Mackall <mpm@selenic.com> wrote:
> [...]
> > > +	if (nt->dev_status) {
> > 
> > Why not simply call net_dev_is_up?
> 
> The flags field values are really BSD legacy-ish stuff and should not be
> used internally. IFF_UP etc, do not have the necessary atomic properties.
> 
> Use netif_running() instead.

Ok, thanks for letting me know about that. I'll make the change.

Satyam
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynami..., Satyam Sharma, (Wed Jul 4, 7:07 am)

Re: [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dy..., Keiichi KII, (Wed Jul 4, 7:49 am)

Re: [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dy..., Satyam Sharma, (Wed Jul 4, 8:25 am)

Re: [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dy..., Joel Becker, (Thu Jul 5, 3:04 am)

[PATCH -mm 9/9] netconsole: Support dynamic reconfiguration ..., Satyam Sharma, (Wed Jul 4, 7:08 am)

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurat..., KII Keiichi, (Sat Jul 7, 2:33 pm)

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurat..., Satyam Sharma, (Sat Jul 7, 3:38 pm)

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurat..., Joel Becker, (Sat Jul 7, 2:01 am)

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurat..., Satyam Sharma, (Sat Jul 7, 3:48 am)

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurat..., Joel Becker, (Sat Jul 7, 4:18 am)

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurat..., Satyam Sharma, (Wed Jul 4, 9:21 am)

[PATCH -mm 8/9] netconsole: Update documentation for dynamic..., Satyam Sharma, (Wed Jul 4, 7:08 am)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., Keiichi KII, (Thu Jul 5, 8:58 am)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., Satyam Sharma, (Thu Jul 5, 9:55 am)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., KII Keiichi, (Sat Jul 7, 2:33 pm)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., Satyam Sharma, (Sat Jul 7, 4:35 pm)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., Satyam Sharma, (Thu Jul 5, 10:03 am)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., Joel Becker, (Thu Jul 5, 2:52 am)

Re: [PATCH -mm 8/9] netconsole: Update documentation for dyn..., Satyam Sharma, (Thu Jul 5, 5:38 am)

[PATCH -mm 7/9] netconsole: Support multiple logging targets, Satyam Sharma, (Wed Jul 4, 7:08 am)

Re: [PATCH -mm 7/9] netconsole: Support multiple logging tar..., KII Keiichi, (Sat Jul 7, 2:33 pm)

Re: [PATCH -mm 7/9] netconsole: Support multiple logging tar..., Satyam Sharma, (Sat Jul 7, 3:46 pm)

[PATCH -mm 6/9] netconsole: Update documentation for multipl..., Satyam Sharma, (Wed Jul 4, 7:08 am)

Re: [PATCH -mm 6/9] netconsole: Update documentation for mul..., Matt Mackall, (Wed Jul 4, 10:01 am)

Re: [PATCH -mm 6/9] netconsole: Update documentation for mul..., Satyam Sharma, (Wed Jul 4, 2:11 pm)

[PATCH -mm 5/9] netconsole: Introduce dev_status member, Satyam Sharma, (Wed Jul 4, 7:08 am)

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member, Joel Becker, (Thu Jul 5, 2:39 am)

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member, Satyam Sharma, (Thu Jul 5, 5:36 am)

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member, Matt Mackall, (Wed Jul 4, 9:56 am)

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member, Stephen Hemminger, (Thu Jul 5, 11:17 am)

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member, Satyam Sharma, (Sat Jul 7, 4:08 am)

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member, Satyam Sharma, (Wed Jul 4, 12:33 pm)

[PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_noti..., Satyam Sharma, (Wed Jul 4, 7:07 am)

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_..., KII Keiichi, (Sat Jul 7, 2:33 pm)

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_..., Satyam Sharma, (Sat Jul 7, 4:28 pm)

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_..., Satyam Sharma, (Sat Jul 7, 4:49 pm)

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_..., Matt Mackall, (Wed Jul 4, 9:59 am)

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_..., Satyam Sharma, (Wed Jul 4, 2:02 pm)

[PATCH -mm 3/9] netconsole: Introduce netconsole_target, Satyam Sharma, (Wed Jul 4, 7:07 am)

[PATCH -mm 2/9] netconsole: Code simplification, Satyam Sharma, (Wed Jul 4, 7:07 am)

Re: [PATCH -mm 2/9] netconsole: Code simplification, Matt Mackall, (Wed Jul 4, 9:46 am)

Re: [PATCH -mm 2/9] netconsole: Code simplification, Satyam Sharma, (Wed Jul 4, 1:43 pm)

[PATCH -mm 1/9] netconsole: Cleanups, codingstyle, prettyfic..., Satyam Sharma, (Wed Jul 4, 7:07 am)

Navigation

Popular discussions


linux-kernel:
monstr	[PATCH 27/56] microblaze_v2: support for a.out
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Rafael J. Wysocki	[Bug #10493] mips BCM47XX compile error
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Colocation donated by:

Who's online

There are currently 11 users and 947 guests online.

Online users

Syndicate