login
Header Space

 
 

Re: [RFC 12/26] ext2 white-out support

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Blunck <jblunck@...>
Cc: <linux-fsdevel@...>, <linux-kernel@...>, Bharata B Rao <bharata@...>
Date: Tuesday, July 31, 2007 - 12:36 pm

On Mon, Jul 30, 2007 at 06:13:35PM +0200, Jan Blunck wrote:

I think storing whiteouts on the branches is wrong. It creates all sort of
nasty cases when people actually try to use unioning. Imagine a (no-so
unlikely) scenario where you have 2 unions, and they share a branch. If you
create a whiteout in one union on that shared branch, the whiteout magically
affects the other union as well! Whiteouts are a union-level construct, and
therefore storing them at the branch level is wrong.

If you store whiteouts on the branches, you'll probably want readdir to not
include them. That's relatively cheap if you have a whiteout bit in the
inode, but I don't think filesystems should be forced to use up rather
prescious inode bits for whiteouts/opaqueness [1].

Really the only sane way of keeping track of whiteouts seems some external
store. We did an experiment with Unionfs, and moving the whiteout handling
to effectively a "library" that did all the dirty work cleaned up the code
considerably [2,3].


Out of curiosity, how do you keep track of opaqueness while the fs is
mounted?

Josef 'Jeff' Sipek.

[1] http://www.mail-archive.com/linux-fsdevel@vger.kernel.org/msg02904.html
[2] http://www.filesystems.org/unionfs-odf.txt
[3] http://download.filesystems.org/unionfs/unionfs-2.0-odf/linux-2.6.20-rc6-odf1.diff.gz

-- 
UNIX is user-friendly ... it's just selective about who it's friends are
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC 12/26] ext2 white-out support, Jan Blunck, (Mon Jul 30, 12:13 pm)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Tue Jul 31, 12:36 pm)
Re: [RFC 12/26] ext2 white-out support, Jan Engelhardt, (Wed Aug 1, 1:58 pm)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Wed Aug 1, 2:03 pm)
Re: [RFC 12/26] ext2 white-out support, Mark Williamson, (Tue Jul 31, 1:03 pm)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Tue Jul 31, 1:16 pm)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Tue Jul 31, 1:00 pm)
Re: [RFC 12/26] ext2 white-out support, Hans-Peter Jansen, (Wed Aug 1, 6:00 am)
Re: [RFC 12/26] ext2 white-out support, Jan Engelhardt, (Wed Aug 1, 2:01 pm)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Wed Aug 1, 7:43 am)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Tue Jul 31, 1:11 pm)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Thu Aug 2, 6:26 am)
Re: [RFC 12/26] ext2 white-out support, Dave Kleikamp, (Wed Aug 1, 11:23 am)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Wed Aug 1, 2:44 pm)
Re: [RFC 12/26] ext2 white-out support, Ph. Marek, (Thu Aug 2, 1:24 am)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Thu Aug 2, 8:12 am)
Re: [RFC 12/26] ext2 white-out support, Dave Kleikamp, (Wed Aug 1, 3:10 pm)
Re: [RFC 12/26] ext2 white-out support, Josef Sipek, (Wed Aug 1, 3:33 pm)
Re: [RFC 12/26] ext2 white-out support, Jörn, (Thu Aug 2, 1:50 pm)
Re: [RFC 12/26] ext2 white-out support, Jeremy Maitin-Shepard, (Thu Aug 2, 2:15 pm)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Thu Aug 2, 7:55 am)
Re: [RFC 12/26] ext2 white-out support, Dave Kleikamp, (Wed Aug 1, 3:52 pm)
Re: [RFC 12/26] ext2 white-out support , Erez Zadok, (Wed Aug 1, 6:06 pm)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Thu Aug 2, 8:05 am)
Re: [RFC 12/26] ext2 white-out support, Theodore Tso, (Mon Jul 30, 11:45 pm)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Tue Jul 31, 3:44 am)
Re: [RFC 12/26] ext2 white-out support, Theodore Tso, (Tue Jul 31, 6:53 am)
Re: [RFC 12/26] ext2 white-out support, Pavel Machek, (Thu Aug 2, 3:31 pm)
Re: [RFC 12/26] ext2 white-out support, Andreas Dilger, (Tue Jul 31, 4:32 am)
Re: [RFC 12/26] ext2 white-out support, Jan Blunck, (Tue Jul 31, 5:08 am)
speck-geostationary