login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
July
»
31
Re: [rft] Kill junk from s2ram resume paths
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Rafael J. Wysocki <rjw@...>
To: Stefan Seyfried <seife@...>
Cc: Pavel Machek <pavel@...>, <suspend-devel@...>, kernel list <linux-kernel@...>
Subject:
Re: [rft] Kill junk from s2ram resume paths
Date: Tuesday, July 31, 2007 - 11:03 am
On Tuesday, 31 July 2007 16:43, Stefan Seyfried wrote:
quoted text
> On Tue, Jul 31, 2007 at 04:01:40PM +0200, Pavel Machek wrote: > > Hi! > > > > > > > > # Running in *copy* of this code, somewhere in low 1MB. > > > > > > > > > > > > - movb __PLACEHOLDER__0_xa1, %al ; outb %al, __PLACEHOLDER__0_x80 > > > > > > > > > > Well, what was this for? > > > > > > > > Debugging leds on port 80. I still have that card somewhere > > > > :-). Interesting parties can reinsert it. > > > > > > Ah, I see. > > > > > > Hmm, can you please write about that in the chanelog more explicitly? > > > Or just comment it out with a "uncomment this to get ..." text? > > > > I still need someone with x86-64 to test it for me before I submit it > > properly ;-). Updated patch follows. > > Compiling right now. > > > Pavel > > > > diff --git a/arch/i386/kernel/acpi/wakeup.S b/arch/i386/kernel/acpi/wakeup.S > > index 1415da1..9cebef7 100644 > > --- a/arch/i386/kernel/acpi/wakeup.S > > +++ b/arch/i386/kernel/acpi/wakeup.S > > @@ -28,21 +28,6 @@ #define BEEP \ > > movb , %al; \ > > outb %al, ; > > > > -#define BEEP \ > > - inb , %al; \ > > - outb %al, __PLACEHOLDER__0_x80; \ > > - movb , %al; \ > > - outb %al, ; \ > > - outb %al, __PLACEHOLDER__0_x80; \ > > - movb $-74, %al; \ > > - outb %al, ; \ > > - outb %al, __PLACEHOLDER__0_x80; \ > > - movb $-119, %al; \ > > - outb %al, ; \ > > - outb %al, __PLACEHOLDER__0_x80; \ > > - movb , %al; \ > > - outb %al, ; > > - > > ALIGN > > .align 4096 > > ENTRY(wakeup_start) > > This hunk rejected for me (against 2.6.23-rc1), but i'm testing x86_64, so > it did not matter ;-)
I think it's gone in favor of the more sophisticated beeping support. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[rft] Kill junk from s2ram resume paths
, Pavel Machek
, (Tue Jul 31, 8:12 am)
Re: [rft] Kill junk from s2ram resume paths
, Rafael J. Wysocki
, (Tue Jul 31, 9:20 am)
Re: [rft] Kill junk from s2ram resume paths
, Pavel Machek
, (Tue Jul 31, 9:18 am)
Re: [rft] Kill junk from s2ram resume paths
, Rafael J. Wysocki
, (Tue Jul 31, 9:49 am)
Re: [rft] Kill junk from s2ram resume paths
, Pavel Machek
, (Tue Jul 31, 10:01 am)
Re: [rft] Kill junk from s2ram resume paths
, Stefan Seyfried
, (Tue Jul 31, 10:43 am)
Re: [rft] Kill junk from s2ram resume paths
, Stefan Seyfried
, (Wed Aug 1, 5:10 pm)
Re: [rft] Kill junk from s2ram resume paths
, Rafael J. Wysocki
, (Tue Jul 31, 11:03 am)
Re: [rft] Kill junk from s2ram resume paths
, Pavel Machek
, (Tue Jul 31, 10:58 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
monstr
[PATCH 27/56] microblaze_v2: support for a.out
Andrew Morton
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
mdew .
Re: [patch] CFS scheduler, v4
Gabriel C
Re: 2.6.21-mm1
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Willy Tarreau
Re: [PATCH] tcp: splice as many packets as possible at once
Linus Torvalds
Re: [GIT]: Networking
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
12 users
and
969 guests
online.
Online users
strcmp
zeekec
dataentryemplo
bacterialyeast
reflectivetpey
freebabysample
boschdiswasher
baskettime94
manuelacraigvz
go24kt
JohnSwem123
expertseoservi
Syndicate