On Sun, 01 Jul 2007 12:42:33 -0400
bo yang <bo.yang@lsi.com> wrote:
quoted text > Driver will skip physical devices scan for the first time if the
> fast_load is set.
>
All your patches are wordwrapped and will need to be resent.
Also, there are multiple trivial errors in here, pretty much all of which
would have been detected had you run scripts/checkpatch.pl across the
diffs:
quoted text > + */
> +static unsigned int fast_load = 0;
Unneeded initialisation
quoted text > +static int megasas_slave_alloc(struct scsi_device *sdev) {
Missing newline
quoted text > + struct megasas_instance *instance ;
unneeded space
quoted text > + int tmp_fastload = fast_load;
> + instance = megasas_lookup_instance(sdev->host->host_no);
Missing blank line.
quoted text > + if (tmp_fastload && sdev->channel < MEGASAS_MAX_PD_CHANNELS) {
> + if ((sdev->id == MEGASAS_MAX_DEV_PER_CHANNEL -1) &&
> + (sdev->channel == MEGASAS_MAX_PD_CHANNELS - 1)) {
> + /* If fast load option was set and scan for last device is
> + * over, reset the fast_load flag so that during a possible
> + * next scan, devices can be made available
> + */
> + fast_load = 0;
> + }
> + return -ENXIO;
> + }
> +
> + return 0;
> +}
> +
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH 2/4] scsi: megaraid_sas -- add module param fast_... , Andrew Morton , (Tue Jul 3, 5:45 pm)