login
Header Space

 
 

Re: [PATCH 3/3] ACPI autoloading - Create __mod_acpi_device_table symbol for all acpi drivers.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Henrique de Moraes Holschuh <hmh@...>
Cc: Thomas Renninger <trenn@...>, linux-kernel <linux-kernel@...>, linux-acpi <linux-acpi@...>, Kay Sievers <kasievers@...>
Date: Tuesday, July 3, 2007 - 3:11 am

My $0.02 on thinkpad_acpi & HID's...

1. moving to DMI binding from PNP-id binding
sounds like a step in the wrong direction.

Are there thinkpads that you need to support that don't export IBM0068?

There is a long tradition of DMI information being copy/pasted
and being invalid.  While the thinkpad BIOS guys are probably
above average here, they're probably not immune from this issue.

At the end of the day, I'd be astonished if somebody told me that
the Windows thinkpad platform driver binds via DMI strings instead
of binding to IBM0068 -- which was likely invented for this sole purpose.

2. IBM_PCI_HID = ACPI_PCI_HOST_HID = PCI_ROOT_HID_STRING = "PNP0A03"

There is nothing IBM specific about a PCI root bridge.
If you need to use this one, please call it PCI_ROOT_HID_STRING.

thanks,
-Len
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 3/3] ACPI autoloading - Create __mod_acpi_device_..., Henrique de Moraes Holschuh..., (Sun Jun 17, 6:49 pm)
Re: [PATCH 3/3] ACPI autoloading - Create __mod_acpi_device_..., Henrique de Moraes Holschuh..., (Tue Jun 19, 5:27 pm)
Re: [PATCH 3/3] ACPI autoloading - Create __mod_acpi_device_..., Len Brown, (Tue Jul 3, 3:11 am)
Re: [PATCH 3/3] ACPI autoloading - Create __mod_acpi_device_..., Henrique de Moraes Holschuh..., (Tue Jul 3, 11:06 am)
speck-geostationary