Re: BSG: BLK_DEV_BSG=y , BLOCK=n compile error

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <James.Bottomley@...>, <nix.or.die@...>
Cc: <linux-kernel@...>, <fujita.tomonori@...>, <linux-scsi@...>, <tomof@...>
Date: Saturday, July 28, 2007 - 10:45 am

From: Gabriel C <nix.or.die@googlemail.com>
Subject: BSG: BLK_DEV_BSG=y , BLOCK=n compile error
Date: Sat, 28 Jul 2007 14:54:02 +0200


Thanks, this has already been addressed.

http://marc.info/?l=linux-kernel&m=118534836402440&w=2


James, could you add the patch to scsi-rc-fixes? Thanks.

---
From: Paul Mundt <lethal@linux-sh.org>
Subject: [PATCH] bsg: Fix build for CONFIG_BLOCK=n

BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
errors, starting with a parse error on the request_queue_t definition.
Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
option back in to the block.

Caught with a randconfig on sh.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 block/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index ca2ef4e..2484e0e 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -49,8 +49,6 @@ config LSF
 
 	  If unsure, say Y.
 
-endif # BLOCK
-
 config BLK_DEV_BSG
 	bool "Block layer SG support v4 (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
@@ -64,4 +62,6 @@ config BLK_DEV_BSG
 	protocols (e.g. Task Management Functions and SMP in Serial
 	Attached SCSI).
 
+endif # BLOCK
+
 source block/Kconfig.iosched
-- 
1.5.2.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
BSG: BLK_DEV_BSG=y , BLOCK=n compile error, Gabriel C, (Sat Jul 28, 8:54 am)
Re: BSG: BLK_DEV_BSG=y , BLOCK=n compile error, FUJITA Tomonori, (Sat Jul 28, 10:45 am)
Re: BSG: BLK_DEV_BSG=y , BLOCK=n compile error, Gabriel C, (Sat Jul 28, 11:16 am)