login
Header Space

 
 

Re: [patch] mm: reduce pagetable-freeing latencies

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Benjamin Herrenschmidt <benh@...>
Cc: Peter Zijlstra <peterz@...>, Andi Kleen <andi@...>, Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, <linux-kernel@...>
Date: Saturday, July 28, 2007 - 1:54 am

On Sat, 28 Jul 2007, Benjamin Herrenschmidt wrote:

That doesn't sound like the best way to me at all.  Using two means
of buffering, one with preemption enabled and the other not, seems
complex and prone to error (perhaps not while you're working on it,
but later on).  We do already have that problem (the i_mmap_lock case
versus the others), but it's not a complication I'd want to extend.

The onstack array seems fine to me, even if you do end up deciding on
an array of one.  Is there any evidence that it's a problem getting a
page for the freeing (other than in circumstances that are already
badly slowed down)?  It's obvious that we need a fallback route,
but optimizing throughput on that route seems premature.

Hugh
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] mm: reduce pagetable-freeing latencies, Ingo Molnar, (Tue Jul 24, 4:38 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Tue Jul 24, 5:40 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Andrew Morton, (Tue Jul 24, 4:54 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Ingo Molnar, (Tue Jul 24, 7:22 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Tue Jul 24, 5:40 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Andi Kleen, (Tue Jul 24, 8:13 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Tue Jul 24, 5:29 pm)
Re: [patch] mm: reduce pagetable-freeing latencies, Peter Zijlstra, (Wed Jul 25, 2:44 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Fri Jul 27, 9:36 pm)
Re: [patch] mm: reduce pagetable-freeing latencies, Hugh Dickins, (Sat Jul 28, 1:54 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Sat Jul 28, 6:36 pm)
Re: [patch] mm: reduce pagetable-freeing latencies, Andi Kleen, (Wed Jul 25, 5:46 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Wed Jul 25, 6:08 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Andi Kleen, (Wed Jul 25, 6:26 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Wed Jul 25, 6:46 am)
Re: [patch] mm: reduce pagetable-freeing latencies, Hugh Dickins, (Thu Jul 26, 1:11 pm)
Re: [patch] mm: reduce pagetable-freeing latencies, Benjamin Herrenschmidt, (Thu Jul 26, 5:35 pm)
speck-geostationary