Home » Mailing list archives » linux-kernel » 2007 » July » 27

Re: [PATCH] CodingStyle: proscribe do-while without braces.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Krzysztof Halasa <khc@...>
To: Andrew Morton <akpm@...>
Cc: Josh Triplett <josht@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>, <linux-sparse@...>
Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces.
Date: Friday, July 27, 2007 - 12:00 pm

Andrew Morton <akpm@linux-foundation.org> writes:


It's certainly true WRT things like indentation but IMHO it shouldn't
go that far, and if it goes, it should be non-braced version.

If we prefer non-braced versions of "if" and "while", it would be
a bit strange to require braces with "do while", wouldn't it?

Sparse warnings... I think it shouldn't complain either, unless
called with extra parameter.


Perhaps some pointer to a bad-looking example so I can see for myself?
-- 
Krzysztof Halasa
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] CodingStyle: proscribe do-while without braces., Josh Triplett, (Thu Jul 26, 5:37 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Krzysztof Halasa, (Thu Jul 26, 8:18 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Stefan Richter, (Thu Jul 26, 8:42 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Randy Dunlap, (Thu Jul 26, 9:17 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Andrew Morton, (Thu Jul 26, 8:59 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Stefan Richter, (Fri Jul 27, 3:41 am)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Andrew Morton, (Fri Jul 27, 3:53 am)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Stefan Richter, (Fri Jul 27, 1:13 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Andrew Morton, (Thu Jul 26, 8:35 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Krzysztof Halasa, (Fri Jul 27, 12:00 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Josh Triplett, (Fri Jul 27, 1:05 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Andrew Morton, (Fri Jul 27, 2:27 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Josh Triplett, (Fri Jul 27, 2:52 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Krzysztof Halasa, (Fri Jul 27, 1:44 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Andrew Morton, (Thu Jul 26, 5:44 pm)
Re: [PATCH] CodingStyle: proscribe do-while without braces., Josh Triplett, (Thu Jul 26, 5:54 pm)