login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
July
»
26
Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Ian McDonald <ian.mcdonald@...>
To: Jesper Juhl <jesper.juhl@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Andrea Bittau <a.bittau@...>, Arnaldo Carvalho de Melo <acme@...>, <dccp@...>
Subject:
Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()
Date: Thursday, July 26, 2007 - 7:16 pm
On 7/27/07, Jesper Juhl <jesper.juhl@gmail.com> wrote:
quoted text
> > Greetings, > > There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm(). > If we hit the 'default:' case of the 'switch' statement, then we > return without freeing 'opt', thus leaking 'struct dccp_opt_pend' > bytes. > The leak is fixed easily enough by adding a kfree(opt); before the > return statement. > The patch also changes the layout of the 'switch' to be more in line > with CodingStyle. > > Patch has been compile tested. > > Please consider merging. > > > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz> -- Web1:
http://wand.net.nz/~iam4/
Web2:
http://www.jandi.co.nz
Blog:
http://iansblog.jandi.co.nz
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH][dccp] Fix memory leak and clean up style - dccp_feat...
, Jesper Juhl
, (Thu Jul 26, 6:39 pm)
Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_...
, Ian McDonald
, (Thu Jul 26, 7:16 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Theodore Tso
Re: -mm merge plans for 2.6.23 -- sys_fallocate
Amit K. Arora
[RFC] Heads up on sys_fallocate()
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 011/196] sysfs: Fix a copy-n-paste typo in comment
git
:
linux-netdev
:
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
Re: [GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
1051 guests
online.
Online users
shante88996
zeekec
Syndicate