Hi,
On Tuesday 24 July 2007, Jordan Crouse wrote:
quoted text > > The Coverity checker spotted the following array overrun in
> > drivers/ide/pci/cs5535.c:
>
> <-- snip -->
>
> > if (speed >= XFER_UDMA_0 && speed <= XFER_UDMA_7)
> > reg |= cs5535_udma_timings[speed - XFER_UDMA_0];
Not a bug per se since the upper layer will never feed this function
with speed > XFER_UDMA_4 (thanks to ->ultra_mask being set to 0x1f).
Worth fixing anyway.
quoted text > Fix is attached. Somebody got overzealous - the 5535 only supports
> up to UDMA4, which matches the array.
applied, thanks
Bart
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: drivers/ide/pci/cs5535.c: array overrun , Bartlomiej Zolnierkiewicz... , (Thu Jul 26, 3:11 pm)