login
Header Space

 
 

Re: [PATCH 2/8] i386: bitops: Rectify bogus "Ir" constraints

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Satyam Sharma <ssatyam@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, David Howells <dhowells@...>, Nick Piggin <nickpiggin@...>, Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, <jh@...>
Date: Monday, July 23, 2007 - 12:30 pm

> Whoa, thanks for explaining that to me -- I didn't know, obviously. I had

These bit operations only allow 8 bit immediates, so 0..255 would
be correct. N might work from the 4.1 docs, but I don't know if it works 
in all old supported gccs (3.2+)

However I is definitely not wrong and most bit numbers are small anyways.

-Andi
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Satyam Sharma, (Mon Jul 23, 12:05 pm)
Re: [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Denis Vlasenko, (Mon Jul 30, 1:57 pm)
Re: [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Satyam Sharma, (Mon Jul 30, 9:07 pm)
Re: [PATCH 4/8] i386: bitops: Kill volatile-casting of memor..., Benjamin Herrenschmidt, (Tue Jul 24, 5:49 am)
[PATCH 3/8] i386: bitops: Rectify bogus "+m" constraints, Satyam Sharma, (Mon Jul 23, 12:05 pm)
[PATCH 2/8] i386: bitops: Rectify bogus "Ir" constraints, Satyam Sharma, (Mon Jul 23, 12:05 pm)
Re: [PATCH 2/8] i386: bitops: Rectify bogus "Ir" constraints, Andi Kleen, (Mon Jul 23, 12:30 pm)
Re: [PATCH 8/8] i386: bitops: smp_mb__{before, after}_clear_..., Jeremy Fitzhardinge, (Tue Jul 24, 3:48 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered..., Jeremy Fitzhardinge, (Tue Jul 24, 5:31 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered..., Benjamin Herrenschmidt, (Tue Jul 24, 5:52 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered..., Benjamin Herrenschmidt, (Tue Jul 24, 5:36 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered..., Benjamin Herrenschmidt, (Tue Jul 24, 5:37 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered..., Benjamin Herrenschmidt, (Tue Jul 24, 6:32 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered..., Jeremy Fitzhardinge, (Mon Jul 23, 1:49 pm)
[PATCH 1/8] i386: bitops: Update/correct comments, Satyam Sharma, (Mon Jul 23, 12:05 pm)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm__..., Jeremy Fitzhardinge, (Mon Jul 23, 12:23 pm)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm__..., Jeremy Fitzhardinge, (Mon Jul 23, 1:39 pm)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm__..., Jeremy Fitzhardinge, (Mon Jul 23, 2:28 pm)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm__..., Jeremy Fitzhardinge, (Mon Jul 23, 4:40 pm)
speck-geostationary