Home » Mailing list archives » linux-kernel » 2007 » July » 23

Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Peter Zijlstra
Subject: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
Date: Monday, July 23, 2007 - 4:38 am

On Mon, 2007-07-23 at 12:21 +0100, Mel Gorman wrote:


Ugh, the fix landed in another patch :-(

updated patch below.

---
Daniel recently spotted that __GFP_ZERO is not (and has never been)
part of GFP_LEVEL_MASK. I could not find a reason for this in the
original patch: 3977971c7f09ce08ed1b8d7a67b2098eb732e4cd in the -bk
tree.

This of course is in stark contradiction with the comment accompanying
GFP_LEVEL_MASK.
---
 include/linux/gfp.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-2/include/linux/gfp.h
===================================================================
--- linux-2.6-2.orig/include/linux/gfp.h
+++ linux-2.6-2/include/linux/gfp.h
@@ -56,7 +56,7 @@ struct vm_area_struct;
 /* if you forget to add the bitmask here kernel will crash, period */
 #define GFP_LEVEL_MASK (__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_FS| \
 			__GFP_COLD|__GFP_NOWARN|__GFP_REPEAT| \
-			__GFP_NOFAIL|__GFP_NORETRY|__GFP_COMP| \
+			__GFP_NOFAIL|__GFP_NORETRY|__GFP_COMP|__GFP_ZERO| \
 			__GFP_NOMEMALLOC|__GFP_HARDWALL|__GFP_THISNODE| \
 			__GFP_MOVABLE)
 


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Peter Zijlstra, (Mon Jul 23, 3:03 am)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Mel Gorman, (Mon Jul 23, 4:21 am)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Peter Zijlstra, (Mon Jul 23, 4:38 am)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Mel Gorman, (Mon Jul 23, 5:30 am)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Andrew Morton, (Mon Jul 23, 11:37 am)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Peter Zijlstra, (Mon Jul 23, 11:40 am)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Christoph Lameter, (Mon Jul 23, 2:43 pm)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Andrew Morton, (Mon Jul 23, 3:13 pm)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Linus Torvalds, (Mon Jul 23, 3:41 pm)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Christoph Lameter, (Mon Jul 23, 3:50 pm)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Andrew Morton, (Mon Jul 23, 3:56 pm)
Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK, Christoph Lameter, (Mon Jul 23, 4:00 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Mon Jul 23, 4:17 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Peter Zijlstra, (Mon Jul 23, 11:01 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Peter Zijlstra, (Mon Jul 23, 11:48 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 12:09 am)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 12:14 am)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Peter Zijlstra, (Tue Jul 24, 12:24 am)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 12:35 am)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 12:07 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Andrew Morton, (Tue Jul 24, 12:25 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 12:36 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Andrew Morton, (Tue Jul 24, 3:10 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 4:00 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Andrew Morton, (Tue Jul 24, 4:12 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Christoph Lameter, (Tue Jul 24, 4:58 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Andrew Morton, (Tue Jul 24, 5:06 pm)
Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK, Mel Gorman, (Wed Jul 25, 6:06 am)