Home » Mailing list archives » linux-kernel » 2007 » July » 23

Re: "build-id" changes break sparc64

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Sam Ravnborg
Subject: Re: "build-id" changes break sparc64
Date: Sunday, July 22, 2007 - 11:22 pm

On Sun, Jul 22, 2007 at 11:01:55PM -0700, Roland McGrath wrote:

Reading Documentation/kbuild/makefiles.txt:
LDFLAGS_MODULE      Options for $(LD) when linking modules

        LDFLAGS_MODULE is used to set specific flags for $(LD) when
        linking the .ko files used for modules.

So it seems to be documented as such.

Browsing the source it looks like a bug that LDFLAGS_MODULE is used in
cmd_link_multi-m.
I suggest you to do the following:
Remove '-r' from LDFLAGS_MODULE in top-level Makefile
Hardcode '-r' in cmd_link_multi-m and remove LDFLAGS_MODULE in the same.
Hardcode '-r' in Makefile,modpost
Add your stuff to LDFLAGS_MODULE in toplevel Makefile.

Sorry for not prrviding a preliminary patch but away from my dev box
with no easy source access.

	Sam
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
"build-id" changes break sparc64, David Miller, (Sun Jul 22, 1:23 am)
Re: "build-id" changes break sparc64, Roland McGrath, (Sun Jul 22, 1:59 am)
Re: "build-id" changes break sparc64, David Miller, (Sun Jul 22, 7:18 pm)
Re: "build-id" changes break sparc64, Roland McGrath, (Sun Jul 22, 11:01 pm)
Re: "build-id" changes break sparc64, Paul Mackerras, (Sun Jul 22, 11:13 pm)
[PATCH] Move --build-id option, Roland McGrath, (Sun Jul 22, 11:14 pm)
Re: "build-id" changes break sparc64, Sam Ravnborg, (Sun Jul 22, 11:22 pm)
Re: "build-id" changes break sparc64, Sam Ravnborg, (Sun Jul 22, 11:27 pm)
Re: [PATCH] Move --build-id option, Sam Ravnborg, (Sun Jul 22, 11:42 pm)
Re: "build-id" changes break sparc64, Roland McGrath, (Mon Jul 23, 12:26 am)
Re: [PATCH] Move --build-id option, Roland McGrath, (Mon Jul 23, 1:09 am)
[PATCH] Use LDFLAGS_MODULE only for .ko links, Roland McGrath, (Mon Jul 23, 1:12 am)
Re: "build-id" changes break sparc64, Sam Ravnborg, (Mon Jul 23, 1:14 am)
Re: [PATCH] Use LDFLAGS_MODULE only for .ko links, Sam Ravnborg, (Mon Jul 23, 1:16 am)
Re: "build-id" changes break sparc64, Roland McGrath, (Mon Jul 23, 1:18 am)
Re: "build-id" changes break sparc64, Sam Ravnborg, (Mon Jul 23, 1:24 am)
Re: "build-id" changes break sparc64, Alan Modra, (Mon Jul 23, 2:25 am)
Re: "build-id" changes break sparc64, Al Viro, (Mon Jul 23, 4:49 am)
Re: "build-id" changes break sparc64, Sam Ravnborg, (Mon Jul 23, 11:00 am)
Re: "build-id" changes break sparc64, Al Viro, (Mon Jul 23, 11:56 am)
Re: "build-id" changes break sparc64, Roland McGrath, (Mon Jul 23, 12:12 pm)
Re: "build-id" changes break sparc64, Adrian Bunk, (Mon Jul 23, 12:13 pm)
Re: "build-id" changes break sparc64, Al Viro, (Mon Jul 23, 12:39 pm)
Re: "build-id" changes break sparc64, Roland McGrath, (Mon Jul 23, 1:05 pm)
Re: "build-id" changes break sparc64, Sam Ravnborg, (Mon Jul 23, 1:33 pm)