Re: [-mm patch] unionfs: make functions static

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Josef Sipek <jsipek@...>

To: Adrian Bunk <bunk@...>

Cc: Andrew Morton <akpm@...>, <ezk@...>, <jsipek@...>, <linux-kernel@...>, <unionfs@...>

Subject: Re: [-mm patch] unionfs: make functions static

Date: Sunday, July 1, 2007 - 9:42 pm

On Sun, Jul 01, 2007 at 10:23:30PM +0200, Adrian Bunk wrote:
quoted text> This patch makes some needlessly global functions static.
> 
...
quoted text> --- linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c.old	2007-07-01 00:05:02.000000000 +0200
> +++ linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c	2007-07-01 00:06:05.000000000 +0200
> @@ -18,6 +18,8 @@
>  
>  #include "union.h"
>  
> +static int realloc_dentry_private_data(struct dentry *dentry);
> +
>  /* is the filename valid == !(whiteout for a file or opaque dir marker) */

I forget who said it, but someone wasn't very happy with prototypes like
that in .c files. What's the prefered way - are they ok for static symbols?

Josef "Jeff" Sipek.

-- 
We have joy, we have fun, we have Linux on a Sun...
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

2.6.22-rc6-mm1, Andrew Morton, (Thu Jun 28, 6:43 am)

Oops with touch and unknown uid [was Re: 2.6.22-rc6-mm1], J.A. , (Sun Jul 22, 5:48 pm)

Re: Oops with touch and unknown uid [was Re: 2.6.22-rc6-mm1], Andrew Morton, (Mon Jul 23, 2:12 am)

Re: Oops with touch and unknown uid [was Re: 2.6.22-rc6-mm1], Randy Dunlap, (Sun Jul 22, 7:41 pm)

Re: 2.6.22-rc6-mm1, Nish Aravamudan, (Fri Jul 13, 8:58 pm)

[-mm patch] fix SND_CS5530=y, ISA=n compilation, Adrian Bunk, (Mon Jul 9, 6:56 pm)

Re: [-mm patch] fix SND_CS5530=y, ISA=n compilation, Takashi Iwai, (Tue Jul 10, 5:35 am)

[-mm patch] XFS: fix powerpc compat compile error, Adrian Bunk, (Sat Jul 7, 5:11 pm)

2.6.22-rc6-mm1: git-kgdb breaks sh compilation, Adrian Bunk, (Sat Jul 7, 4:03 am)

Re: 2.6.22-rc6-mm1: git-kgdb breaks sh compilation, Jason Wessel, (Sun Jul 8, 1:10 am)

2.6.22-rc6-mm1: UNION_FS=y + BLOCK=n = compile error, Adrian Bunk, (Fri Jul 6, 10:01 pm)

Re: 2.6.22-rc6-mm1: UNION_FS=y + BLOCK=n = compile error , Erez Zadok, (Sun Jul 8, 7:58 am)

2.6.22-rc6-mm1: SLUB_DEBUG=n compile error, Adrian Bunk, (Fri Jul 6, 9:50 pm)

Re: 2.6.22-rc6-mm1: SLUB_DEBUG=n compile error, Christoph Lameter, (Fri Jul 6, 10:03 pm)

Re: 2.6.22-rc6-mm1: SLUB_DEBUG=n compile error, Adrian Bunk, (Fri Jul 6, 10:09 pm)

Re: 2.6.22-rc6-mm1: SLUB_DEBUG=n compile error, Christoph Lameter, (Fri Jul 6, 10:13 pm)

Re: 2.6.22-rc6-mm1, Badari Pulavarty, (Fri Jul 6, 5:31 pm)

kgdb Bad IO access (was: 2.6.22-rc6-mm1), Tilman Schmidt, (Fri Jul 6, 10:03 am)

Re: kgdb Bad IO access, Jason Wessel, (Fri Jul 6, 1:51 pm)

preemption counter havoc on kgdb-taken faults (was: kgdb Bad..., Jan Kiszka, (Fri Jul 6, 2:15 pm)

Re: preemption counter havoc on kgdb-taken faults, Jason Wessel, (Fri Jul 6, 2:24 pm)

Re: preemption counter havoc on kgdb-taken faults, Jan Kiszka, (Fri Jul 6, 3:19 pm)

Re: kgdb Bad IO access, Jason Wessel, (Fri Jul 6, 1:33 pm)

Re: kgdb Bad IO access (was: 2.6.22-rc6-mm1), Andrew Morton, (Fri Jul 6, 12:45 pm)

[-mm patch] kernel/sched.c: make 2 functions static, Adrian Bunk, (Thu Jul 5, 7:23 pm)

[-mm patch] make arch/i386/xen/mmu.c:xen_pgd_pin() static, Adrian Bunk, (Thu Jul 5, 7:22 pm)

Re: [-mm patch] make arch/i386/xen/mmu.c:xen_pgd_pin() static, Jeremy Fitzhardinge, (Thu Jul 5, 8:09 pm)

[-mm patch] arch/i386/xen/mmu.c must #include <linux/sched.h>, Adrian Bunk, (Thu Jul 5, 7:22 pm)

Re: [-mm patch] arch/i386/xen/mmu.c must #include <linux/..., Jeremy Fitzhardinge, (Thu Jul 5, 8:08 pm)

[-mm patch] arch/i386/xen/events.c should #include <asm/x..., Adrian Bunk, (Thu Jul 5, 7:22 pm)

Re: [-mm patch] arch/i386/xen/events.c should #include <a..., Jeremy Fitzhardinge, (Thu Jul 5, 8:10 pm)

2.6.22-rc6-mm1: Xen + Numa = compile error, Adrian Bunk, (Wed Jul 4, 3:00 pm)

[PATCH] xen: can't support numa yet, Jeremy Fitzhardinge, (Wed Jul 4, 8:32 pm)

[-mm patch] unexport dvb_pll_configure, Adrian Bunk, (Sun Jul 1, 4:24 pm)

Re: [-mm patch] unexport dvb_pll_configure, Michael Krufky, (Sun Jul 1, 5:29 pm)

[-mm patch] unionfs: make functions static, Adrian Bunk, (Sun Jul 1, 4:23 pm)

Re: [-mm patch] unionfs: make functions static, Josef Sipek, (Sun Jul 1, 9:42 pm)

Re: [-mm patch] unionfs: make functions static, Adrian Bunk, (Sun Jul 1, 10:27 pm)

Re: [-mm patch] unionfs: make functions static, Josef Sipek, (Mon Jul 2, 4:38 pm)

Re: [-mm patch] unionfs: make functions static, Satyam Sharma, (Sun Jul 1, 10:21 pm)

[-mm patch] remove security/selinux/hooks.c:enabled_mmap_min..., Adrian Bunk, (Sun Jul 1, 4:23 pm)

Re: [-mm patch] remove security/selinux/hooks.c:enabled_mmap..., James Morris, (Sun Jul 1, 6:39 pm)

[-mm patch] kernel/power/main.c: make code static, Adrian Bunk, (Sun Jul 1, 4:23 pm)

Re: [-mm patch] kernel/power/main.c: make code static, Rafael J. Wysocki, (Sun Jul 1, 7:12 pm)

[-mm patch] unexport mmap_min_addr, Adrian Bunk, (Sun Jul 1, 4:23 pm)

Re: [-mm patch] unexport mmap_min_addr, James Morris, (Sun Jul 1, 6:38 pm)

[-mm patch] make cpuidle_replace_governor() static, Adrian Bunk, (Sun Jul 1, 4:23 pm)

[-mm patch] make struct dccp_li_cachep static, Adrian Bunk, (Sun Jul 1, 4:23 pm)

2.6.22-rc6-mm1: TUNER_TEA5761 kconfig fixes, Adrian Bunk, (Sun Jul 1, 4:23 pm)

Re: 2.6.22-rc6-mm1: TUNER_TEA5761 kconfig fixes, Michael Krufky, (Sun Jul 1, 5:29 pm)

[-mm patch] unexport bprm_mm_init, Adrian Bunk, (Sun Jul 1, 4:23 pm)

[-mm patch] fix include/asm-m68k/fb.h, Adrian Bunk, (Sun Jul 1, 4:22 pm)

[-mm patch] fix duplicate CONFIG_DMAR Makefile line, Adrian Bunk, (Sun Jul 1, 4:22 pm)

Re: [-mm patch] fix duplicate CONFIG_DMAR Makefile line, Keshavamurthy, Anil S, (Mon Jul 2, 8:30 pm)

Re: 2.6.22-rc6-mm1, , (Fri Jun 29, 10:50 am)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Fri Jun 29, 5:01 pm)

Re: 2.6.22-rc6-mm1, , (Sat Jun 30, 12:17 am)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Sat Jun 30, 1:15 am)

Re: 2.6.22-rc6-mm1, Sam Ravnborg, (Sat Jun 30, 5:10 pm)

Re: 2.6.22-rc6-mm1, Satyam Sharma, (Sun Jul 1, 1:31 am)

Re: 2.6.22-rc6-mm1, Sam Ravnborg, (Sun Jul 1, 2:52 am)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Sat Jun 30, 5:39 pm)

Re: 2.6.22-rc6-mm1, Roman Zippel, (Sat Jun 30, 9:53 pm)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Tue Jul 3, 4:36 pm)

Re: 2.6.22-rc6-mm1, Jeremy Fitzhardinge, (Sat Jun 30, 12:22 pm)

Re: 2.6.22-rc6-mm1, Roman Zippel, (Fri Jun 29, 10:17 am)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Fri Jun 29, 4:58 pm)

Re: 2.6.22-rc6-mm1, Roman Zippel, (Sat Jun 30, 9:48 pm)

Re: 2.6.22-rc6-mm1, Mariusz Kozlowski, (Fri Jun 29, 8:32 am)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Fri Jun 29, 4:47 pm)

Re: 2.6.22-rc6-mm1, Michal Marek, (Sat Jun 30, 4:40 am)

Re: 2.6.22-rc6-mm1, Sergei Shtylyov, (Fri Jun 29, 8:54 am)

Re: 2.6.22-rc6-mm1, Jason Wessel, (Mon Jul 2, 9:49 am)

Re: 2.6.22-rc6-mm1, Sergei Shtylyov, (Mon Jul 2, 10:23 am)

Re: 2.6.22-rc6-mm1, Jason Wessel, (Mon Jul 2, 10:45 am)

Re: 2.6.22-rc6-mm1, Paul Mackerras, (Mon Jul 2, 7:21 pm)

2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Adrian Bunk, (Thu Jun 28, 4:40 pm)

Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Jeremy Fitzhardinge, (Thu Jun 28, 4:49 pm)

Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Eric W. Biederman, (Sun Jul 1, 11:37 am)

Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Jeremy Fitzhardinge, (Sun Jul 1, 12:33 pm)

Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Eric W. Biederman, (Sun Jul 1, 4:31 pm)

Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Jeremy Fitzhardinge, (Sun Jul 1, 6:13 pm)

Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present, Adrian Bunk, (Sun Jul 1, 4:23 pm)

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64, Zan Lynx, (Thu Jun 28, 4:40 pm)

Re: 2.6.22-rc6-mm1 Intel DMAR crash on AMD x86_64, Zach Carter, (Thu Jun 28, 7:50 pm)

Re: 2.6.22-rc6-mm1: io_apic build error, Randy Dunlap, (Thu Jun 28, 4:09 pm)

Re: 2.6.22-rc6-mm1: io_apic build error, Andrew Morton, (Thu Jun 28, 4:23 pm)

Re: 2.6.22-rc6-mm1: io_apic build error, John Keller, (Thu Jun 28, 5:47 pm)

2.6.22-rc6-mm1: multiple definition of `check_reset', Adrian Bunk, (Thu Jun 28, 3:29 pm)

Re: 2.6.22-rc6-mm1: multiple definition of `check_reset', Andrew Morton, (Thu Jun 28, 4:01 pm)

[PATCH 2.6.22-rc6-mm1] compile error when CONFIG_DM_NETLINK ..., Dave Kleikamp, (Thu Jun 28, 10:49 am)

Re: [PATCH 2.6.22-rc6-mm1] compile error when CONFIG_DM_NETL..., Alasdair G Kergon, (Thu Jun 28, 11:34 am)

[patch -mm] s390: struct bin_attribute changes, Heiko Carstens, (Thu Jun 28, 9:39 am)

Re: [patch -mm] s390: struct bin_attribute changes, Greg KH, (Thu Jun 28, 5:08 pm)

RE: [patch -mm] s390: struct bin_attribute changes, Zhang, Rui, (Thu Jun 28, 12:04 pm)

[patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM, Heiko Carstens, (Thu Jun 28, 9:37 am)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Andrew Morton, (Thu Jun 28, 2:06 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Geert Uytterhoeven, (Thu Jun 28, 2:27 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Andrew Morton, (Thu Jun 28, 2:38 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Geert Uytterhoeven, (Thu Jun 28, 2:47 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Andrew Morton, (Thu Jun 28, 4:29 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Alan Cox, (Thu Jun 28, 6:25 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Geert Uytterhoeven, (Fri Jun 29, 9:08 am)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Roman Zippel, (Thu Jun 28, 6:51 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Alan Cox, (Thu Jun 28, 7:12 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Roman Zippel, (Thu Jun 28, 8:06 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Jeff Dike, (Thu Jun 28, 6:45 pm)

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_..., Andrew Morton, (Thu Jun 28, 7:01 pm)

[patch -mm] s390: rename CPU_IDLE to S390_CPU_IDLE, Heiko Carstens, (Thu Jun 28, 9:39 am)

Re: [patch -mm] s390: rename CPU_IDLE to S390_CPU_IDLE, Ingo Molnar, (Thu Jun 28, 11:03 am)

Re: 2.6.22-rc6-mm1, Gabriel C, (Thu Jun 28, 8:08 am)

Re: 2.6.22-rc6-mm1, Andrew Morton, (Thu Jun 28, 1:54 pm)

Navigation

Popular discussions


linux-kernel:
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Parag Warudkar	BUG: soft lockup - CPU#1 stuck for 15s! [swapper:0]
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Heiko Carstens	Re: -mm merge plans for 2.6.23 -- sys_fallocate
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 0/37] dccp: Feature negotiation - last call for comments
David Miller	Re: [GIT]: Networking
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	Re: iptables very slow after commit784544739a25c30637397ace5489eeb6e15d7d49

Colocation donated by:

Online users

Syndicate