login
Login / Register
Header Space

 
 

Home » Mailing list archives » linux-kernel » 2007 » July » 19

[PATCH] [19/58] x86_64: Don't use softirq save locks in smp_call_function

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <ak@...>
To: <patches@...>, <linux-kernel@...>
Subject: [PATCH] [19/58] x86_64: Don't use softirq save locks in smp_call_function
Date: Thursday, July 19, 2007 - 5:55 am

It is not fully softirq safe anyways.

Can't do a WARN_ON unfortunately because it could trigger in the 
panic case.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86_64/kernel/smp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/x86_64/kernel/smp.c
===================================================================
--- linux.orig/arch/x86_64/kernel/smp.c
+++ linux/arch/x86_64/kernel/smp.c
@@ -386,9 +386,9 @@ int smp_call_function_single (int cpu, v
 		return 0;
 	}
 
-	spin_lock_bh(&call_lock);
+	spin_lock(&call_lock);
 	__smp_call_function_single(cpu, func, info, nonatomic, wait);
-	spin_unlock_bh(&call_lock);
+	spin_unlock(&call_lock);
 	put_cpu();
 	return 0;
 }
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/58] First batch of x86 patches for .23, Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [58/58] x86: remove support for the Rise CPU, Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [PATCH] [58/58] x86: remove support for the Rise CPU, Alan Cox, (Thu Jul 19, 6:45 am)
Re: [PATCH] [58/58] x86: remove support for the Rise CPU, Adrian Bunk, (Thu Jul 19, 6:48 am)
Re: [PATCH] [58/58] x86: remove support for the Rise CPU, Alan Cox, (Thu Jul 19, 7:13 am)
Re: [PATCH] [58/58] x86: remove support for the Rise CPU, Andi Kleen, (Thu Jul 19, 8:03 am)
Re: [PATCH] [58/58] x86: remove support for the Rise CPU, Jeff Garzik, (Thu Jul 19, 10:56 am)
[PATCH] [57/58] x86_64: check remote IRR bit before migratin..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [56/58] x86: round_jiffies() for i386 and x86-64 non..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [55/58] i386: add reference to the arguments, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [54/58] x86: Make Alt-SysRq-p display the debug regi..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [53/58] x86: PM_TRACE support, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [52/58] i386: fix section mismatch warnings in mtrr, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [51/58] i386: fix machine rebooting, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [50/58] x86_64: mcelog tolerant level cleanup, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [49/58] x86_64: support poll() on /dev/mcelog, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [48/58] x86_64: O_EXCL on /dev/mcelog, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [47/58] i386: insert unclaimed MMCONFIG resources, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [46/58] x86_64: fake apicid_to_node mapping for fake..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [45/58] x86_64: fake pxm-to-node mapping for fake numa, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [44/58] x86_64: extract helper function from e820_re..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [43/58] x86_64: Quicklist support for x86_64, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [42/58] i386: timer_irq_works() static again, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [41/58] i386: arch/i386/kernel/i8253.c should #inclu..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [40/58] i386: remapped_pgdat_init() static, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [39/58] i386: minor nx handling adjustment, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [38/58] i386: smp-alt-once option is only useful wit..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [37/58] x86_64: remove unused variable maxcpus, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [36/58] x86_64: minor exception trace variables clea..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [35/58] i386: allow debuggers to access the vsyscall..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [34/58] x86_64: ia32entry adjustments, Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [PATCH] [34/58] x86_64: ia32entry adjustments, Jeff Garzik, (Thu Jul 19, 10:46 am)
Re: [PATCH] [34/58] x86_64: ia32entry adjustments, Jan Beulich, (Mon Aug 6, 6:43 am)
[PATCH] [33/58] x86_64: Avoid too many remote cpu references..., Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [PATCH] [33/58] x86_64: Avoid too many remote cpu refere..., Christoph Hellwig, (Thu Jul 19, 6:21 am)
Re: [PATCH] [33/58] x86_64: Avoid too many remote cpu refere..., Andi Kleen, (Thu Jul 19, 6:41 am)
Re: [PATCH] [33/58] x86_64: Avoid too many remote cpu refere..., Adrian Bunk, (Thu Jul 19, 6:55 am)
[PATCH] [32/58] x86_64: time.c white space wreckage cleanup, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [31/58] x86_64: apic.c coding style janitor work, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [30/58] x86: share hpet.h with i386, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [29/58] x86_64: fiuxp pt_reqs leftovers, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [28/58] x86_64: Fix APIC typo, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [27/58] x86_64: Remove dead code and other janitor w..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [26/58] x86_64: Use generic xtime init, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [25/58] x86_64: use generic cmos update, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [24/58] x86_64: Untangle asm/hpet.h from asm/timex.h, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [23/58] i386: remove pit_interrupt_hook, Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [22/58] x86_64: hpet tsc calibration fix broken smi ..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [21/58] i386: Reserve the right performance counter ..., Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [PATCH] [21/58] i386: Reserve the right performance coun..., Björn, (Thu Jul 19, 6:21 am)
Re: [PATCH] [21/58] i386: Reserve the right performance coun..., Andi Kleen, (Thu Jul 19, 6:45 am)
[PATCH] [20/58] x86: Always probe the NMI watchdog, Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [PATCH] [20/58] x86: Always probe the NMI watchdog, Björn, (Thu Jul 19, 6:24 am)
Re: [PATCH] [20/58] x86: Always probe the NMI watchdog, Andi Kleen, (Thu Jul 19, 6:42 am)
[PATCH] [19/58] x86_64: Don't use softirq save locks in smp_..., Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [PATCH] [19/58] x86_64: Don't use softirq save locks in ..., Satyam Sharma, (Thu Jul 19, 8:16 am)
Re: [PATCH] [19/58] x86_64: Don't use softirq save locks in ..., Andi Kleen, (Thu Jul 19, 8:19 am)
[PATCH] [18/58] x86_64: remove extra extern declaring about ..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [17/58] i386: Add L3 cache support to AMD CPUID4 emu..., Andi Kleen, (Thu Jul 19, 5:55 am)
Re: [patches] [PATCH] [17/58] i386: Add L3 cache support to ..., Andreas Herrmann, (Fri Jul 20, 1:15 pm)
Re: [patches] [PATCH] [17/58] i386: Add L3 cache support to ..., Andreas Herrmann, (Fri Jul 20, 1:00 pm)
[PATCH] [16/58] x86_64: Use new shared sched_clock in x86-64..., Andi Kleen, (Thu Jul 19, 5:55 am)
[PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Daniel Walker, (Thu Jul 19, 12:51 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Mathieu Desnoyers, (Thu Jul 19, 11:11 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Fri Jul 20, 4:27 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Mathieu Desnoyers, (Fri Jul 20, 10:12 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Fri Jul 20, 11:14 am)
[PATCH] 80386 and 80486 cmpxchg64 and cmpxchg64_local fallback, Mathieu Desnoyers, (Fri Jul 20, 12:49 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Mathieu Desnoyers, (Fri Jul 20, 11:22 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Mathieu Desnoyers, (Fri Jul 20, 10:39 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Mathieu Desnoyers, (Thu Jul 19, 11:47 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock (cmpxchg8b), Mathieu Desnoyers, (Fri Jul 20, 12:18 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock (cmpxchg8b), Nick Piggin, (Fri Jul 20, 1:07 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock (cmpxchg8b), Mathieu Desnoyers, (Fri Jul 20, 1:47 am)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Thu Jul 19, 1:13 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Daniel Walker, (Thu Jul 19, 1:15 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Thu Jul 19, 1:22 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Daniel Walker, (Thu Jul 19, 1:31 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Thu Jul 19, 1:38 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Daniel Walker, (Thu Jul 19, 1:43 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Andi Kleen, (Thu Jul 19, 2:00 pm)
Re: [PATCH] [15/58] i386: Rewrite sched_clock, Daniel Walker, (Thu Jul 19, 2:00 pm)
[PATCH] [14/58] x86_64: Add on_cpu_single, Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [14/58] x86_64: Add on_cpu_single, Satyam Sharma, (Thu Jul 19, 7:09 am)
Re: [PATCH] [14/58] x86_64: Add on_cpu_single, Andi Kleen, (Thu Jul 19, 8:07 am)
[PATCH] [13/58] x86: Separate checking of unsynchronized and..., Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [12/58] x86_64: Add vDSO for x86-64 with gettimeofda..., Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [12/58] x86_64: Add vDSO for x86-64 with gettime..., Daniel Walker, (Tue Aug 21, 12:25 pm)
Re: [PATCH] [12/58] x86_64: Add vDSO for x86-64 with gettime..., Andi Kleen, (Tue Aug 21, 2:45 pm)
Re: [PATCH] [12/58] x86_64: Add vDSO for x86-64 with gettime..., Andrew Morton, (Tue Aug 21, 2:40 pm)
[PATCH] [11/58] x86: Support __attribute__((__cold__)) in gc..., Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [10/58] i386: Move all simple string operations out ..., Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [9/58] x86_64: Always use builtin memcpy on gcc 4.3, Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [9/58] x86_64: Always use builtin memcpy on gcc ..., Oleg Verych, (Sat Jul 21, 7:16 pm)
Re: [PATCH] [9/58] x86_64: Always use builtin memcpy on gcc ..., Denis Vlasenko, (Sat Jul 21, 8:29 pm)
Re: [PATCH] [9/58] x86_64: Always use builtin memcpy on gcc ..., Andi Kleen, (Sat Jul 21, 7:27 pm)
[PATCH] [8/58] x86_64: Use string instruction memcpy/memset ..., Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [8/58] x86_64: Use string instruction memcpy/mem..., Jan Engelhardt, (Thu Jul 19, 12:43 pm)
Re: [PATCH] [8/58] x86_64: Use string instruction memcpy/mem..., Yinghai Lu, (Thu Jul 19, 1:00 pm)
[PATCH] [7/58] x86_64: various cleanups in NUMA scan node, Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node, Yinghai Lu, (Thu Jul 19, 1:15 pm)
Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node, David Rientjes, (Thu Jul 19, 5:01 pm)
Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node, Andi Kleen, (Thu Jul 19, 1:21 pm)
Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node, Yinghai Lu, (Thu Jul 19, 1:38 pm)
Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node, Andi Kleen, (Thu Jul 19, 4:00 pm)
[PATCH] [6/58] x86_64: Use LOCAL_DISTANCE and REMOTE_DISTAN..., Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [5/58] x86_64: Report the pending irq if available i..., Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [5/58] x86_64: Report the pending irq if availab..., Ingo Molnar, (Thu Jul 19, 6:23 am)
[PATCH] [4/58] x86_64: Don't rely on a unique IO-APIC ID, Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [3/58] x86_64: asm/ptrace.h needs linux/compiler.h, Andi Kleen, (Thu Jul 19, 5:54 am)
[PATCH] [2/58] x86_64: Tell gcc to only align stack to 8 bytes, Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [PATCH] [2/58] x86_64: Tell gcc to only align stack to 8..., Serge Belyshev, (Thu Jul 19, 7:50 am)
Re: [PATCH] [2/58] x86_64: Tell gcc to only align stack to 8..., Andi Kleen, (Thu Jul 19, 8:06 am)
Re: [PATCH] [2/58] x86_64: Tell gcc to only align stack to 8..., Chuck Ebbert, (Thu Jul 19, 10:42 am)
[PATCH] [1/58] x86: Always flush pages in change_page_attr, Andi Kleen, (Thu Jul 19, 5:54 am)
Re: [patches] [PATCH] [1/58] x86: Always flush pages in chan..., Jan Beulich, (Mon Aug 6, 6:15 am)
Re: [patches] [PATCH] [1/58] x86: Always flush pages in chan..., Andi Kleen, (Mon Aug 6, 6:36 am)
Re: [patches] [PATCH] [1/58] x86: Always flush pages in chan..., Jan Beulich, (Mon Aug 6, 6:49 am)

Mail archive search
Enter your search terms.
Optionally limit your search to a specific mailing list.
advanced
Colocation donated by:
Who's online
There are currently 4 users and 1144 guests online.

Online users

Syndicate
Syndicate content
© 2007 KernelTrap.  |  Powered by Drupal.  |  Legal statement.
speck-geostationary