login
Header Space

 
 

[PATCH 4/6] cpuset write vmscan

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ethan Solomita <solo@...>
Cc: <linux-mm@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>, Christoph Lameter <clameter@...>
Date: Tuesday, July 17, 2007 - 5:35 pm

Direct reclaim: cpuset aware writeout

During direct reclaim we traverse down a zonelist and are carefully
checking each zone if its a member of the active cpuset. But then we call
pdflush without enforcing the same restrictions. In a larger system this
may have the effect of a massive amount of pages being dirtied and then either

A. No writeout occurs because global dirty limits have not been reached

or

B. Writeout starts randomly for some dirty inode in the system. Pdflush
   may just write out data for nodes in another cpuset and miss doing
   proper dirty handling for the current cpuset.

In both cases dirty pages in the zones of interest may not be affected
and writeout may not occur as necessary.

Fix that by restricting pdflush to the active cpuset. Writeout will occur
from direct reclaim the same way as without a cpuset.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Acked-by: Ethan Solomita <solo@google.com>

---

Patch against 2.6.22-rc6-mm1

diff -uprN -X 0/Documentation/dontdiff 3/mm/vmscan.c 4/mm/vmscan.c
--- 3/mm/vmscan.c	2007-07-11 21:16:14.000000000 -0700
+++ 4/mm/vmscan.c	2007-07-11 21:16:26.000000000 -0700
@@ -1183,7 +1183,8 @@ unsigned long try_to_free_pages(struct z
 		 */
 		if (total_scanned > sc.swap_cluster_max +
 					sc.swap_cluster_max / 2) {
-			wakeup_pdflush(laptop_mode ? 0 : total_scanned, NULL);
+			wakeup_pdflush(laptop_mode ? 0 : total_scanned,
+				&cpuset_current_mems_allowed);
 			sc.may_writepage = 1;
 		}
 

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/6] cpuset aware writeback, Ethan Solomita, (Tue Jul 17, 5:23 pm)
Re: [PATCH 0/6] cpuset aware writeback, Ethan Solomita, (Tue Sep 11, 9:32 pm)
[PATCH 6/6] cpuset dirty limits, Ethan Solomita, (Tue Sep 11, 9:42 pm)
Re: [PATCH 6/6] cpuset dirty limits, Andrew Morton, (Fri Sep 14, 7:15 pm)
Re: [PATCH 6/6] cpuset dirty limits, Christoph Lameter, (Mon Sep 17, 3:00 pm)
Re: [PATCH 6/6] cpuset dirty limits, Ethan Solomita, (Tue Sep 18, 8:23 pm)
[PATCH 5/6] cpuset write vm writeout, Ethan Solomita, (Tue Sep 11, 9:41 pm)
[PATCH 4/6] cpuset write vmscan, Ethan Solomita, (Tue Sep 11, 9:40 pm)
[PATCH 3/6] cpuset write throttle, Ethan Solomita, (Tue Sep 11, 9:39 pm)
[PATCH 2/6] cpuset write pdflush nodemask, Ethan Solomita, (Tue Sep 11, 9:38 pm)
[PATCH 1/6] cpuset write dirty map, Ethan Solomita, (Tue Sep 11, 9:36 pm)
Re: [PATCH 1/6] cpuset write dirty map, Andrew Morton, (Fri Sep 14, 7:15 pm)
Re: [PATCH 1/6] cpuset write dirty map, Ethan Solomita, (Tue Sep 18, 8:51 pm)
Re: [PATCH 1/6] cpuset write dirty map, Christoph Lameter, (Wed Sep 19, 1:06 pm)
Re: [PATCH 1/6] cpuset write dirty map, Andrew Morton, (Tue Sep 18, 10:14 pm)
Re: [PATCH 1/6] cpuset write dirty map, Christoph Lameter, (Wed Sep 19, 1:08 pm)
Re: [PATCH 1/6] cpuset write dirty map, Christoph Lameter, (Mon Sep 17, 3:10 pm)
Re: [PATCH 1/6] cpuset write dirty map, Satyam Sharma, (Fri Sep 14, 7:47 pm)
Re: [PATCH 1/6] cpuset write dirty map, Andrew Morton, (Fri Sep 14, 8:07 pm)
Re: [PATCH 1/6] cpuset write dirty map, Satyam Sharma, (Fri Sep 14, 8:16 pm)
Re: [PATCH 1/6] cpuset write dirty map, Mike Travis, (Mon Sep 17, 2:37 pm)
Re: [PATCH 0/6] cpuset aware writeback, Christoph Lameter, (Mon Jul 23, 4:18 pm)
Re: [PATCH 0/6] cpuset aware writeback, Ethan Solomita, (Mon Jul 23, 5:30 pm)
Re: [PATCH 0/6] cpuset aware writeback, Christoph Lameter, (Mon Jul 23, 5:53 pm)
[PATCH 6/6] cpuset dirty limits, Ethan Solomita, (Tue Jul 17, 5:37 pm)
[PATCH 5/6] cpuset write vm writeout, Ethan Solomita, (Tue Jul 17, 5:36 pm)
[PATCH 4/6] cpuset write vmscan, Ethan Solomita, (Tue Jul 17, 5:35 pm)
[PATCH 3/6] cpuset write throttle, Ethan Solomita, (Tue Jul 17, 5:34 pm)
[PATCH 2/6] cpuset write pdflush nodemask, Ethan Solomita, (Tue Jul 17, 5:33 pm)
[PATCH 1/6] cpuset write dirty map, Ethan Solomita, (Tue Jul 17, 5:32 pm)
speck-geostationary