* Linus Torvalds <torvalds@linux-foundation.org> wrote:hm, Markus indicated that he tried the v2.6.21.6-cfsv19 patch, and that does not include the time.c change. Markus - does your kernel include the code below? (if yes, please revert it via patch -p1 -R ) Ingo Index: linux/kernel/time.c =================================================================== --- linux.orig/kernel/time.c +++ linux/kernel/time.c @@ -57,14 +57,17 @@ EXPORT_SYMBOL(sys_tz); */ asmlinkage long sys_time(time_t __user * tloc) { - time_t i; - struct timeval tv; + /* + * We read xtime.tv_sec atomically - it's updated + * atomically by update_wall_time(), so no need to + * even read-lock the xtime seqlock: + */ + time_t i = xtime.tv_sec; - do_gettimeofday(&tv); - i = tv.tv_sec; + smp_rmb(); /* sys_time() results are coherent */ if (tloc) { - if (put_user(i,tloc)) + if (put_user(i, tloc)) i = -EFAULT; } return i; @@ -373,6 +376,20 @@ void do_gettimeofday (struct timeval *tv tv->tv_sec = sec; tv->tv_usec = usec; + + /* + * Make sure xtime.tv_sec [returned by sys_time()] always + * follows the gettimeofday() result precisely. This + * condition is extremely unlikely, it can hit at most + * once per second: + */ + if (unlikely(xtime.tv_sec != tv->tv_sec)) { + unsigned long flags; + + write_seqlock_irqsave(&xtime_lock); + update_wall_time(); + write_seqlock_irqrestore(&xtime_lock); + } } EXPORT_SYMBOL(do_gettimeofday); -
| Stephen Rothwell | Announce: Linux-next (Or Andrew's dream :-)) |
| David Miller | [GIT]: Networking |
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| Karl Meyer | PROBLEM: 2.6.23-rc "NETDEV WATCHDOG: eth0: transmit timed out" |
git: | |
| Jakub Narebski | Re: VCS comparison table |
| Johannes Schindelin | [PATCH] Add a birdview-on-the-source-code section to the user manual |
| Guilhem Bonnefille | Re: [FAQ?] Rationale for git's way to manage the index |
| Dana How | [PATCH v2] Custom compression levels for objects and packs |
| Richard Stallman | Real men don't attack straw men |
| Dmitrij Czarkoff | malformatted MMC card fails to mount |
| Jan Stary | 4.1 on ALIX.1C - recommendations? |
| Cinder Cycling Shop | Re: Mountain and Road Bikes Liquidation Sale on 2007 models |
| Леонид Юрьев | [r8169] patch for RTL8102 (5 new MAC/PHY) |
| jamal | Re: [RFC][PATCH] Fixing SA/SP dumps on netlink/af_key |
| Timur Tabi | [PATCH 0/2] QE clock source improvements |
| Herbert Valerio Riedel | [PATCH,RFC] ep93xx_eth: conversion to phylib framework |
