Re: [PATCH 2/6][TAKE7] fallocate() implementation in i386, x86_64 and powerpc

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Christoph Hellwig

Subject: Re: [PATCH 2/6][TAKE7] fallocate() implementation in i386, x86_64 and powerpc

Date: Friday, July 13, 2007 - 7:46 am

On Fri, Jul 13, 2007 at 07:48:58PM +0530, Amit K. Arora wrote:
quoted text> Ok. Since we have only one flag (FALLOC_FL_KEEP_SIZE) and we do not want
> to declare the default mode (FALLOC_ALLOCATE), we can _just_ have this
> flag and remove the other mode too (FALLOC_RESV_SPACE).
> Is this what you are suggesting ?

Yes.

quoted text> Should we need a header file just to declare one flag - i.e.
> FALLOC_FL_KEEP_SIZE (since now there is no point of declaring the two
> modes) ? If "linux/fs.h" is not a good place, will "asm-generic/fcntl.h"
> be a sane place for this flag ?

It might sound a litte silly but is the cleanest thing we could do by
far.  And I suspect there will be more more flags soon..

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/6][TAKE7] fallocate system call, Amit K. Arora, (Fri Jul 13, 5:38 am)

[PATCH 1/6][TAKE7] manpage for fallocate, Amit K. Arora, (Fri Jul 13, 5:46 am)

[PATCH 2/6][TAKE7] fallocate() implementation in i386, x86 ..., Amit K. Arora, (Fri Jul 13, 5:47 am)

[PATCH 3/6][TAKE7] revalidate write permissions for fallocate, Amit K. Arora, (Fri Jul 13, 5:48 am)

[PATCH 4/6][TAKE7] ext4: fallocate support in ext4, Amit K. Arora, (Fri Jul 13, 5:50 am)

[PATCH 5/6][TAKE7] ext4: write support for preallocated blocks, Amit K. Arora, (Fri Jul 13, 5:52 am)

[PATCH 6/6][TAKE7] ext4: change for better extent-to-group ..., Amit K. Arora, (Fri Jul 13, 5:52 am)

Re: [PATCH 2/6][TAKE7] fallocate() implementation in i386, ..., Christoph Hellwig, (Fri Jul 13, 6:21 am)

Re: [PATCH 3/6][TAKE7] revalidate write permissions for fa ..., Christoph Hellwig, (Fri Jul 13, 6:21 am)

Re: [PATCH 1/6][TAKE7] manpage for fallocate, David Chinner, (Fri Jul 13, 7:06 am)

Re: [PATCH 2/6][TAKE7] fallocate() implementation in i386, ..., Amit K. Arora, (Fri Jul 13, 7:18 am)

Re: [PATCH 1/6][TAKE7] manpage for fallocate, Amit K. Arora, (Fri Jul 13, 7:27 am)

Re: [PATCH 3/6][TAKE7] revalidate write permissions for fa ..., Amit K. Arora, (Fri Jul 13, 7:28 am)

Re: [PATCH 2/6][TAKE7] fallocate() implementation in i386, ..., Christoph Hellwig, (Fri Jul 13, 7:46 am)

Re: [PATCH 1/6][TAKE7] manpage for fallocate, Michael Kerrisk, (Sat Jul 14, 1:23 am)

Re: [PATCH 1/6][TAKE7] manpage for fallocate, Amit K. Arora, (Sun Jul 15, 10:32 pm)

fallocate() man page, Michael Kerrisk, (Sun Jul 22, 11:09 pm)

Re: fallocate() man page, Amit K. Arora, (Mon Jul 23, 6:10 am)

Re: fallocate() man page, David Chinner, (Tue Jul 24, 12:06 am)

Re: fallocate() man page, Michael Kerrisk, (Sun Jul 29, 11:21 pm)

Re: fallocate() man page, Michael Kerrisk, (Mon Jul 30, 12:43 pm)

fallocate() man page - darft 2, Michael Kerrisk, (Mon Jul 30, 12:44 pm)

Re: fallocate() man page, Amit K. Arora, (Tue Jul 31, 6:56 am)

Re: fallocate() man page - darft 2, Amit K. Arora, (Thu Aug 2, 10:36 am)

Re: fallocate() man page - darft 2, Michael Kerrisk, (Fri Aug 3, 4:59 am)

Re: fallocate() man page - darft 2, Amit K. Arora, (Sun Aug 5, 11:10 pm)


linux-kernel:
Mel Gorman	Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck	Re: [lm-sensors] Location for thermal drivers
David Woodhouse	Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B	Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra	Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head:
Linux Kernel Mailing List	[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List	USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List	lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List	[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List	[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev:
MERCEDES	Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller	Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller	Re: skb_segment() questions
Shan Wei	[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka	[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git:
Nicolas Sebrecht	git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano	Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff	Re: [PATCH] GIT commit statistics.
Alexandre Julliard	[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett	[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc:
Taisto Qvist XX	Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer	Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier	Re: jetway board sensors (Fintek F71805F)
admin	Drive a 2009 car from R799p/m
Antti Harri	Re: how to create a sha256 hash