Re: [PATCH] Simplify /proc/<pid|self>/exe symlink code

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matt Helsley <matthltc@...>
Cc: Chris Wright <chrisw@...>, <linux-mm@...>, LKML <linux-kernel@...>, Christoph Hellwig <hch@...>, Hallyn, Serge <serue@...>, Peter Zijlstra <peterz@...>
Date: Thursday, July 12, 2007 - 10:21 pm

On Thu, 12 Jul 2007 19:00:12 -0700 Matt Helsley <matthltc@us.ibm.com> wrote:


I wish we had a description of the bug which this fixes.  That email of
Chris's is referencing code which diddles with task_struct.exe_file, but
your patch _adds_ task_struct.exe_file, so I am all confused.

Your patch does lots of fput()s under task_lock(), but fput() can sleep.

Plus what Al said.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Simplify /proc/&lt;pid|self&gt;/exe symlink code, Matt Helsley, (Thu Jul 12, 10:00 pm)
Re: [PATCH] Simplify /proc/<pid|self>/exe symlink code, Andrew Morton, (Thu Jul 12, 10:21 pm)