Home » Mailing list archives » linux-kernel » 2007 » July » 10

Re: [patch 09/10] Remove the SLOB allocator for 2.6.23

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Matt Mackall <mpm@...>
To: Christoph Lameter <clameter@...>
Cc: Nick Piggin <nickpiggin@...>, Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, <linux-kernel@...>, <linux-mm@...>, <suresh.b.siddha@...>, <corey.d.gough@...>, Pekka Enberg <penberg@...>, Denis Vlasenko <vda.linux@...>, Erik Andersen <andersen@...>
Subject: Re: [patch 09/10] Remove the SLOB allocator for 2.6.23
Date: Tuesday, July 10, 2007 - 4:32 am

On Mon, Jul 09, 2007 at 07:11:03PM -0700, Christoph Lameter wrote:

You're delusional.

http://www.kernel.org/hg/linux-2.6/annotate/tip/mm/slob.c

A grand total of 15 lines accounted to you, all of which are
completely trivial. Most of them are turning no-op macros into no-op
but non-inline functions. Not an improvement. Reverting that now on my
todo list, thanks for drawing my attention to it. The remainder is
just churn from your SLUB work.

While you're at it, note the lines from Dimitri, quickly fixing the
breakage you introduced.

Count many more lines from Nick, Pekka, and Akinobu making useful
changes. And note that all three of the real bugs fixed were fairly
hard to hit. It's unlikely that anyone would have ever hit the RCU
bug. The find_order bug only hit allocations of unlikely sizes like
8193 bytes. And SLAB_PANIC triggering is fairly unheard of, and simply
makes the kernel crash slightly sooner anyway.

The only remaining known bug is arguably a problem in nommu that SLOB
shouldn't be papering over.

That's pretty damn stable compared to the other allocators in the
kernel.


Um.. would those be the same kernel standards you pulled out of your
ass to argue SLOB shouldn't exist?

-- 
Mathematics is the supreme nostalgia of our time.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Sat Jul 7, 11:50 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Mon Jul 9, 4:52 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Ingo Molnar, (Sun Jul 8, 3:51 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 12:00 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Andrew Morton, (Sun Jul 8, 2:02 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Mon Jul 9, 5:57 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Sun Jul 8, 10:57 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 12:06 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Mon Jul 9, 9:41 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 9:51 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Mon Jul 9, 10:32 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Mon Jul 9, 9:58 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Tue Jul 10, 2:22 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Tue Jul 10, 3:03 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Andrew Morton, (Mon Jul 9, 12:51 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Mon Jul 9, 7:09 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 1:26 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Mon Jul 9, 9:43 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 9:56 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Mon Jul 9, 10:02 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 10:11 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Tue Jul 10, 4:32 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Tue Jul 10, 9:37 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Tue Jul 10, 10:06 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Wed Jul 11, 2:06 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka J Enberg, (Wed Jul 11, 2:25 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Wed Jul 11, 8:33 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Wed Jul 11, 2:33 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka J Enberg, (Wed Jul 11, 2:36 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Håvard Skinnemoen, (Tue Jul 10, 5:01 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Tue Jul 10, 5:11 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Håvard Skinnemoen, (Tue Jul 10, 5:21 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Tue Jul 10, 3:09 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Tue Jul 10, 6:09 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Tue Jul 10, 7:12 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Andrew Morton, (Mon Jul 9, 2:00 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka Enberg, (Mon Jul 9, 7:04 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Mon Jul 9, 12:08 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka J Enberg, (Tue Jul 10, 4:17 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Tue Jul 10, 4:27 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka Enberg, (Tue Jul 10, 5:31 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Tue Jul 10, 8:02 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Tue Jul 10, 6:12 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Matt Mackall, (Tue Jul 10, 6:40 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Christoph Lameter, (Tue Jul 10, 6:50 pm)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka J Enberg, (Tue Jul 10, 8:57 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Tue Jul 10, 6:09 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Mon Jul 9, 7:16 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka J Enberg, (Mon Jul 9, 9:46 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Pekka Enberg, (Mon Jul 9, 8:47 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Sun Jul 8, 5:43 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Ingo Molnar, (Sun Jul 8, 5:54 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Nick Piggin, (Sun Jul 8, 6:23 am)
Re: [patch 09/10] Remove the SLOB allocator for 2.6.23, Ingo Molnar, (Sun Jul 8, 6:42 am)