Home » Mailing list archives » linux-kernel » 2007 » July » 1

Re: [patch] CFS scheduler, -v18

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Willy Tarreau <w@...>
Cc: <linux-kernel@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Mike Galbraith <efault@...>, Arjan van de Ven <arjan@...>, Thomas Gleixner <tglx@...>, Dmitry Adamushko <dmitry.adamushko@...>, Srivatsa Vaddagiri <vatsa@...>
Subject: Re: [patch] CFS scheduler, -v18
Date: Sunday, July 1, 2007 - 4:45 am

Willy,

could you check whether your current v18 CFS tree has the fix below 
included? I discovered it right after having released v18 so i updated 
the v18 files in place - but maybe you downloaded an early version? I 
thought it's relatively harmless, that it would only affect SCHED_IDLE 
tasks, but maybe it affects nice +19 tasks too on your box!

	Ingo

Index: linux/kernel/sched_fair.c
===================================================================
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -342,8 +342,9 @@ update_stats_enqueue(struct cfs_rq *cfs_
 		s64 tmp;
 
 		if (se->wait_runtime < 0) {
-			tmp = (0 - se->wait_runtime) << NICE_0_SHIFT;
-			key += (tmp * se->load.inv_weight) >> WMULT_SHIFT;
+			tmp = -se->wait_runtime;
+			key += (tmp * se->load.inv_weight) >>
+					(WMULT_SHIFT - NICE_0_SHIFT);
 		} else {
 			tmp = se->wait_runtime * se->load.weight;
 			key -= tmp >> NICE_0_SHIFT;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] CFS scheduler, -v18, Ingo Molnar, (Fri Jun 22, 6:02 pm)
Re: [patch] CFS scheduler, -v18, Vegard Nossum, (Mon Jul 2, 7:44 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Tue Jul 3, 3:15 am)
Re: [patch] CFS scheduler, -v18, Vegard Nossum, (Tue Jul 3, 5:11 am)
Re: [patch] CFS scheduler, -v18, Bill Davidsen, (Mon Jul 2, 10:13 am)
Re: [patch] CFS scheduler, -v18, Dmitry Adamushko, (Mon Jul 2, 9:01 am)
Re: [patch] CFS scheduler, -v18, Vegard Nossum, (Mon Jul 2, 9:43 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Mon Jul 2, 11:50 am)
Re: [patch] CFS scheduler, -v18, Vegard Nossum, (Mon Jul 2, 12:40 pm)
Re: [patch] CFS scheduler, -v18, Mike Galbraith, (Tue Jul 3, 3:12 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Tue Jul 3, 3:22 am)
Re: [patch] CFS scheduler, -v18, Andi Kleen, (Wed Jul 4, 8:11 am)
Re: [patch] CFS scheduler, -v18, Keith Packard, (Tue Jul 3, 4:08 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Tue Jul 3, 4:31 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Mon Jul 2, 2:13 pm)
Re: [patch] CFS scheduler, -v18, Vegard Nossum, (Tue Jul 3, 3:01 am)
Re: [patch] CFS scheduler, -v18, Willy Tarreau, (Sat Jun 30, 5:06 pm)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sun Jul 1, 4:31 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sun Jul 1, 4:45 am)
Re: [patch] CFS scheduler, -v18, Willy Tarreau, (Sun Jul 1, 5:00 am)
RE: [patch] CFS scheduler, -v18, Fortier,Vincent [Montreal]..., (Tue Jun 26, 4:17 pm)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Wed Jun 27, 6:51 am)
Re: [patch] CFS scheduler, -v18, Willy Tarreau, (Sat Jun 23, 9:24 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sun Jun 24, 11:52 am)
Re: [patch] CFS scheduler, -v18, Willy Tarreau, (Sun Jun 24, 1:08 pm)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sun Jun 24, 4:31 pm)
Re: [patch] CFS scheduler, -v18, Antonino Ingargiola, (Sat Jun 23, 6:22 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sat Jun 23, 1:25 pm)
Re: [patch] CFS scheduler, -v18, Antonino Ingargiola, (Sun Jun 24, 6:02 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sun Jun 24, 7:07 am)
Re: [patch] CFS scheduler, -v18, Antonino Ingargiola, (Mon Jun 25, 3:27 am)
Re: [patch] CFS scheduler, -v18, Gene Heskett, (Fri Jun 22, 7:08 pm)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Sat Jun 23, 3:11 am)
Re: [patch] CFS scheduler, -v18, Gene Heskett, (Sat Jun 23, 5:55 am)
Re: [patch] CFS scheduler, -v18, S.Çağlar, (Fri Jun 22, 6:09 pm)
Re: [patch] CFS scheduler, -v18, S.Çağlar, (Fri Jun 22, 6:16 pm)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Fri Jun 22, 6:20 pm)
Re: [patch] CFS scheduler, -v18, Andrew Morton, (Mon Jun 25, 11:02 pm)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Tue Jun 26, 4:38 am)
Re: [patch] CFS scheduler, -v18, Andrew Morton, (Tue Jun 26, 5:00 am)
Re: [patch] CFS scheduler, -v18, Ingo Molnar, (Tue Jun 26, 5:38 am)