login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
June
»
24
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Pavel Machek
Subject:
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks
Date: Sunday, June 24, 2007 - 1:21 pm
Hi!
quoted text
> > > > > Special thanks to Uli Luckas <u.luckas@road.de> for reviewing the previous > > > > > versions of this patch and for very useful comments. > > > > ... > > > > > Reviewed-by: Pavel Machek <pavel@ucw.cz> > > > > > > > > Eh, not sure this header is worth anything. Sometimes I'm lazy and > > > > stop when I see first problem. > > > > > > > > > switch (action) { > > > > > case PM_HIBERNATION_PREPARE: > > > > > case PM_SUSPEND_PREPARE: > > > > > usermodehelper_disabled = 1; > > > > > - return NOTIFY_OK; > > > > > + retval = wait_event_timeout(running_helpers_waitq, > > > > > + atomic_read(&running_helpers) == 0, > > > > > > > > Are you sure here? What happens when atomic variable changes between > > > > the atomic_read and the function call? > > > > > > Er, this is a macro. :-) > > > > > > In fact we rely only on atomic_read(&running_helpers) being still zero after > > > helper_finished() has woken us up, but I think that's acceptable. > > > > > > IOW, if the wait_event_timeout() returns with retval different from zero, this > > > means that atomic_read(&running_helpers) returned zero at one point after > > > we'd set usermodehelper_disabled, which is enough. OTOH, if it doesn't > > > > Ok, can you write short comment explaining that? /* We have set > > usermodehelper_disabled, so any new usermode helpers are not a problem > > */. > > OK, please have a look at the updated patch below.
ACK, and thanks for your patience. Pavel -- (english)
http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RC][PATCH -mm] PM: Prevent frozen user mode helpers from ...
, Rafael J. Wysocki
, (Fri Jun 22, 7:47 am)
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers f ...
, Pavel Machek
, (Fri Jun 22, 2:07 pm)
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers f ...
, Rafael J. Wysocki
, (Fri Jun 22, 2:47 pm)
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers f ...
, Pavel Machek
, (Sun Jun 24, 10:05 am)
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers f ...
, Pavel Machek
, (Sun Jun 24, 1:21 pm)
Re: [RC][PATCH -mm] PM: Prevent frozen user mode helpers f ...
, Rafael J. Wysocki
, (Sun Jun 24, 1:26 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Fortier,Vincent [Montreal]
2.6.21.5 june 30th to july 1st date hang?
Jeff Dike
[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood
[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov
Re: Getting the new RxRPC patches upstream
Stefan Seyfried
Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev
:
Arnaud Ebalard
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt
Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior
[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git
:
Jakub Narebski
Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey
Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder
[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra
Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano
Re: git-rm isn't the inverse action of git-add
openbsd-misc
:
Joachim Schipper
Re: UVC Webcams
Florin Andrei
SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith
Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan
Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.
Re: Real men don't attack straw men
git-commits-head
:
Linux Kernel Mailing List
ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List
m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List
[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List
[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List
mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()
Colocation donated by:
Syndicate