Home » Mailing list archives » linux-kernel » 2007 » June » 11

fix oops on cat /dev/snapshot

Previous thread: Re: ext2 on flash memory by Tomasz Chmielewski on Monday, June 11, 2007 - 4:53 am. (10 messages)

Next thread: [GIT PULL] Blackfin patches for 2.6.22-rc4 by Bryan Wu on Monday, June 11, 2007 - 5:42 am. (1 message)
[view original message]
From: Pavel Machek
Subject: fix oops on cat /dev/snapshot
Date: Monday, June 11, 2007 - 5:17 am

What /dev/snapshot is simply cat-ed -- without ioctls used in normal
operation -- it oopses. This one should fix it.

Signed-off-by: Pavel Machek <pavel@suse.cz>

--- clean-mm/kernel/power/user.c	2007-06-09 16:18:12.000000000 +0200
+++ linux-mm/kernel/power/user.c	2007-06-11 14:06:19.000000000 +0200
@@ -99,6 +99,8 @@
 	ssize_t res;
 
 	data = filp->private_data;
+	if (!data->ready)
+		return -EINVAL;
 	res = snapshot_read_next(&data->handle, count);
 	if (res > 0) {
 		if (copy_to_user(buf, data_of(data->handle), res))

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-


[ message continues ]
[view original message]
From: Rafael J. Wysocki
Subject: Re: fix oops on cat /dev/snapshot
Date: Monday, June 11, 2007 - 7:36 am

I have a patch for that and I'm going to post it in a while if you don't
mind.

I've already posted it once, here: http://lkml.org/lkml/2007/6/10/146

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-


[ message continues ]
[view original message]
From: Pavel Machek
Subject: Re: fix oops on cat /dev/snapshot
Date: Monday, June 11, 2007 - 7:32 am

Aha, go ahead, I did not notice that mail.
										Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-


[ message continues ]
Previous thread: Re: ext2 on flash memory by Tomasz Chmielewski on Monday, June 11, 2007 - 4:53 am. (10 messages)

Next thread: [GIT PULL] Blackfin patches for 2.6.22-rc4 by Bryan Wu on Monday, June 11, 2007 - 5:42 am. (1 message)