Re: 2.6.21-ext4-1 | KernelTrap

> > The same behaviour is needed for delalloc extents to prevent ENOSPC > errors on writeback - the mmap write needs to do the freespace > accounting at the time the page is dirtied and that can only be done > through the ->page_mkwrite callout. Otherwise ENOSPC will occur in > the writeback path and that is a major pain.... > > This may not be a problem for ext4, but I thought I better point > out a couple of the more subtle problems mmap can introduce.... > > Cheers, > > Dave. > -- > Dave Chinner > Principal Engineer > SGI Australian Software Group > > > --- > xfstests/src/Makefile | 7 > xfstests/src/falloc.c | 376 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 381 insertions(+), 2 deletions(-) > > Index: xfs-cmds/xfstests/src/falloc.c > =================================================================== > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ xfs-cmds/xfstests/src/falloc.c 2007-04-30 12:41:13.862302450 +1000 > @@ -0,0 +1,376 @@ > +/* > + * Copyright (c) 2000-2003,2007 Silicon Graphics, Inc. > + * All Rights Reserved. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it would be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write the Free Software Foundation, > + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#include "global.h" > + > +/* should end up include somewhere */ > +#define FA_ALLOCATE 0x1 > +#define FA_DEALLOCATE 0x2 > +#define FA_PREALLOCATE 0x3 > + > +/* ia64 */ > +#define __NR_fallocate 1305 > +/* > + * Block I/O parameterization. A basic block (BB) is the lowest size of > + * filesystem allocation, and must equal 512. Length units given to bio > + * routines are in BB's. > + */ > + > +/* Assume that if we have BTOBB, then we have the rest */ > +#ifndef BTOBB > +#define BBSHIFT 9 > +#define BBSIZE (1<<BBSHIFT) > +#define BBMASK (BBSIZE-1) > +#define BTOBB(bytes) (((__u64)(bytes) + BBSIZE - 1) >> BBSHIFT) > +#define BTOBBT(bytes) ((__u64)(bytes) >> BBSHIFT) > +#define BBTOB(bbs) ((bbs) << BBSHIFT) > +#define OFFTOBBT(bytes) ((__u64)(bytes) >> BBSHIFT) > + > +#define SEEKLIMIT32 0x7fffffff > +#define BBSEEKLIMIT32 BTOBBT(SEEKLIMIT32) > +#define SEEKLIMIT 0x7fffffffffffffffLL > +#define BBSEEKLIMIT OFFTOBBT(SEEKLIMIT) > +#endif > + > +#ifndef OFFTOBB > +#define OFFTOBB(bytes) (((__u64)(bytes) + BBSIZE - 1) >> BBSHIFT) > +#define BBTOOFF(bbs) ((__u64)(bbs) << BBSHIFT) > +#endif > + > +#define FSBTOBB(f) (OFFTOBBT(FSBTOOFF(f))) > +#define BBTOFSB(b) (OFFTOFSB(BBTOOFF(b))) > +#define OFFTOFSB(o) ((o) / blocksize) > +#define FSBTOOFF(f) ((f) * blocksize) > + > +void usage(void) > +{ > + printf("usage: alloc [-b blocksize] [-d dir] [-f file] [-n] [-r] [-t]\n" > + "flags:\n" > + " -n - non-interractive mode\n" > + " -r - real time file\n" > + " -t - truncate on open\n" > + "\n" > + "commands:\n" > + " a [offset] [length] - alloc\n" > + " p [offset] [length] - prealloc\n" > + " f [offset] [length] - free\n" > + " m [offset] [length] - print map\n" > + " s - sync file\n" > + " t [offset] - truncate\n" > + " q - quit\n" > + " h/? - this help\n"); > + > +} > + > +int fd = -1; > +int blocksize; > +char *filename; > + > +/* params are in bytes */ > +void map(off64_t off, off64_t len) > +{ > + struct getbmap bm[2]; > + > + bzero(bm, sizeof(bm)); > + > + bm[0].bmv_count = 2; > + bm[0].bmv_offset = OFFTOBB(off); > + if (len==(off64_t)-1) { /* unsigned... */ > + bm[0].bmv_length = -1; > + printf(" MAP off=%lld, len=%lld [%lld-]\n", > + (long long)off, (long long)len, > + (long long)BBTOFSB(bm[0].bmv_offset)); > + } else { > + bm[0].bmv_length = OFFTOBB(len); > + printf(" MAP off=%lld, len=%lld [%lld,%lld]\n", > + (long long)off, (long long)len, > + (long long)BBTOFSB(bm[0].bmv_offset), > + (long long)BBTOFSB(bm[0].bmv_length)); > + } > + > + printf(" [ofs,count]: start..end\n"); > + for (;;) { > +#ifdef XFS_IOC_GETBMAP > + if (xfsctl(filename, fd, XFS_IOC_GETBMAP, bm) < 0) { > +#else > +#ifdef F_GETBMAP > + if (fcntl(fd, F_GETBMAP, bm) < 0) { > +#else > +bozo! > +#endif > +#endif > + perror("getbmap"); > + break; > + } > + > + if (bm[0].bmv_entries == 0) > + break; > + > + printf(" [%lld,%lld]: ", > + (long long)BBTOFSB(bm[1].bmv_offset), > + (long long)BBTOFSB(bm[1].bmv_length)); > + > + if (bm[1].bmv_block == -1) > + printf("hole"); > + else > + printf("%lld..%lld", > + (long long)BBTOFSB(bm[1].bmv_block), > + (long long)BBTOFSB(bm[1].bmv_block + > + bm[1].bmv_length - 1)); > + printf("\n"); > + } > +} > + > +int > +main(int argc, char **argv) > +{ > + int c; > + char *dirname = NULL; > + int done = 0; > + int status = 0; > + struct flock64 f; > + off64_t len; > + char line[1024]; > + off64_t off; > + int oflags; > + static char *opnames[] = { "alloc", > + "prealloc", > + "free" }; > + int opno; > + static int optab[] = { FA_ALLOCATE, > + FA_PREALLOCATE, > + FA_DEALLOCATE }; > + int rflag = 0; > + struct statvfs64 svfs; > + int tflag = 0; > + int nflag = 0; > + int unlinkit = 0; > + __int64_t v; > + > + while ((c = getopt(argc, argv, "b:d:f:rtn")) != -1) { > + switch (c) { > + case 'b': > + blocksize = atoi(optarg); > + break; > + case 'd': > + if (filename) { > + printf("can't specify both -d and -f\n"); > + exit(1); > + } > + dirname = optarg; > + break; > + case 'f': > + if (dirname) { > + printf("can't specify both -d and -f\n"); > + exit(1); > + } > + filename = optarg; > + break; > + case 'r': > + rflag = 1; > + break; > + case 't': > + tflag = 1; > + break; > + case 'n': > + nflag++; > + break; > + default: > + printf("unknown option\n"); > + usage(); > + exit(1); > + } > + } > + if (!dirname && !filename) > + dirname = "."; > + if (!filename) { > + static char tmpfile[] = "allocXXXXXX"; > + > + mkstemp(tmpfile); > + filename = malloc(strlen(tmpfile) + strlen(dirname) + 2); > + sprintf(filename, "%s/%s", dirname, tmpfile); > + unlinkit = 1; > + } > + oflags = O_RDWR | O_CREAT | (tflag ? O_TRUNC : 0); > + fd = open(filename, oflags, 0666); > + if (!nflag) { > + printf("alloc:\n"); > + printf(" filename %s\n", filename); > + } > + if (fd < 0) { > + perror(filename); > + exit(1); > + } > + if (!blocksize) { > + if (fstatvfs64(fd, &svfs) < 0) { > + perror(filename); > + status = 1; > + goto done; > + } > + blocksize = (int)svfs.f_bsize; > + } > + if (blocksize<0) { > + fprintf(stderr,"illegal blocksize %d\n", blocksize); > + status = 1; > + goto done; > + } > + printf(" blocksize %d\n", blocksize); > + if (rflag) { > + struct fsxattr a; > + > +#ifdef XFS_IOC_FSGETXATTR > + if (xfsctl(filename, fd, XFS_IOC_FSGETXATTR, &a) < 0) { > + perror("XFS_IOC_FSGETXATTR"); > + status = 1; > + goto done; > + } > +#else > +#ifdef F_FSGETXATTR > + if (fcntl(fd, F_FSGETXATTR, &a) < 0) { > + perror("F_FSGETXATTR"); > + status = 1; > + goto done; > + } > +#else > +bozo! > +#endif > +#endif > + > + a.fsx_xflags |= XFS_XFLAG_REALTIME; > + > +#ifdef XFS_IOC_FSSETXATTR > + if (xfsctl(filename, fd, XFS_IOC_FSSETXATTR, &a) < 0) { > + perror("XFS_IOC_FSSETXATTR"); > + status = 1; > + goto done; > + } > +#else > +#ifdef F_FSSETXATTR > + if (fcntl(fd, F_FSSETXATTR, &a) < 0) { > + perror("F_FSSETXATTR"); > + status = 1; > + goto done; > + } > +#else > +bozo! > +#endif > +#endif > + } > + while (!done) { > + char *p; > + > + if (!nflag) printf("alloc> "); > + fflush(stdout); > + if (!fgets(line, 1024, stdin)) break; > + > + p=line+strlen(line); > + if (p!=line&&p[-1]=='\n') p[-1]=0; > + > + opno = 0; > + switch (line[0]) { > + case 'f': > + opno++; > + case 'p': > + opno++; > + case 'a': > + v = strtoll(&line[2], &p, 0); > + if (*p == 'b') { > + off = FSBTOOFF(v); > + p++; > + } else > + off = v; > + if (*p == '__PLACEHOLDER__1_') > + v = -1; > + else > + v = strtoll(p, &p, 0); > + if (*p == 'b') { > + len = FSBTOOFF(v); > + p++; > + } else > + len = v; > + > + printf(" CMD %s, off=%lld, len=%lld\n", > + opnames[opno], (long long)off, (long long)len); > + > + c = syscall(__NR_fallocate, fd, optab[opno], off, len); > + > + if (c < 0) { > + perror(opnames[opno]); > + break; > + } > + > + map(off,len); > + break; > + case 'm': > + p = &line[1]; > + v = strtoll(p, &p, 0); > + if (*p == 'b') { > + off = FSBTOOFF(v); > + p++; > + } else > + off = v; > + if (*p == '__PLACEHOLDER__1_') > + len = -1; > + else { > + v = strtoll(p, &p, 0); > + if (*p == 'b') > + len = FSBTOOFF(v); > + else > + len = v; > + } > + map(off,len); > + break; > + case 't': > + p = &line[1]; > + v = strtoll(p, &p, 0); > + if (*p == 'b') > + off = FSBTOOFF(v); > + else > + off = v; > + printf(" TRUNCATE off=%lld\n", (long long)off); > + if (ftruncate64(fd, off) < 0) { > + perror("ftruncate"); > + break; > + } > + break; > + case 's': > + printf(" SYNC\n"); > + fsync(fd); > + break; > + case 'q': > + printf(" QUIT\n"); > + done = 1; > + break; > + case '?': > + case 'h': > + usage(); > + break; > + default: > + printf("unknown command '%s'\n", line); > + break; > + } > + } > + if (!nflag) printf("\n"); > +done: > + if (fd != -1) > + close(fd); > + if (unlinkit) > + unlink(filename); > + exit(status); > + /* NOTREACHED */ > +} > Index: xfs-cmds/xfstests/src/Makefile > =================================================================== > --- xfs-cmds.orig/xfstests/src/Makefile 2007-04-23 16:22:06.000000000 +1000 > +++ xfs-cmds/xfstests/src/Makefile 2007-04-30 12:18:42.126750949 +1000 > @@ -14,7 +14,7 @@ TARGETS = dirstress fill fill2 getpagesi > > LINUX_TARGETS = loggen xfsctl bstat t_mtab getdevicesize \ > preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \ > - fs_perms testx looptest locktest unwritten_mmap > + fs_perms testx looptest locktest unwritten_mmap falloc > > IRIX_TARGETS = open_unlink > > @@ -98,7 +98,10 @@ trunc: trunc.o > > fs_perms: fs_perms.o > $(LINKTEST) > - > + > +falloc: falloc.o > + $(LINKTEST) > + > testx: testx.o > $(LINKTEST)


linux-kernel:
Alexey Dobriyan	Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michael Moore	Re: underage models, pre teen models, lolita porn, young preteens, little lolitas
Alex Riesen	Re: [PATCH 4/7] lib: Introduce strnstr()
Thomas Gleixner	[ANNOUNCE] 2.6.31-rc6-rt2
Mathieu Desnoyers	Re: Linux 2.6.25-rc2
git:
Blaisorblade	git-unpack-objects < pack file in repository doesn't work!
Matthieu Moy	Re: Cloning empty repositories, was Re: What is the idea for bare repositories?
Linus Torvalds	Re: Untracked working tree files
Peter Karlsson	Re: CRLF problems with Git on Win32
Johannes Schindelin	Re: [PATCH 4/4] git-rebase -i: New option to support rebase with merges
linux-netdev:
Alan Menegotto	Re: Linux networking implementation and packet capture
Andrew Morton	Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
Timo Teräs	ip xfrm policy semantics
Jarek Poplawski	Re: [PATCH]: Fix queueing return values...
David Miller	Re: [PATCH 1/2] netdev: bfin_mac: enable bfin_mac net dev driver for BF51x
git-commits-head:
Linux Kernel Mailing List	Blackfin: don't give CPU its own line in traps output
Linux Kernel Mailing List	No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List	x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List	MIPS: SMTC: Fix lockup in smtc_distribute_timer
Linux Kernel Mailing List	powerpc: gamecube/wii: usbgecko bootwrapper console support
openbsd-misc:
Aaron Mason	Re: Defending OpenBSD Performance
Henning Brauer	Re: Defending OpenBSD Performance
Henning Brauer	Re: Defending OpenBSD Performance
Christiano Farina Haesbaert	Re: Defending OpenBSD Performance
Nick Holland	Re: 1 out of 3 hunks failed--saving rejects to kerberosV/src/lib/krb5/crypto.c.rej