Hello together,

The description of this option needs to be extended to be correct:)

--- /usr/src/linux-2.6.21/drivers/usb/input/Kconfig     2007-04-27 18:02:46=
.000000000 +0200
+++ Kconfig.new 2007-05-02 16:47:56.000000000 +0200
@@ -28,12 +28,12 @@
        depends on USB_HID && INPUT=3Dn
=20
 config USB_HIDINPUT_POWERBOOK
-       bool "Enable support for iBook/PowerBook special keys"
+       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro special=
 keys"
        default n
        depends on USB_HID
        help
          Say Y here if you want support for the special keys (Fn, Numlock)=
 on
-         Apple iBooks and PowerBooks.
+         Apple iBooks, PowerBooks, MacBooks and MacBook Pro's.
=20
          If unsure, say N.

This option is needed on the Apple Intel Laptops, too.
I would suggest to rename USB_HIDINPUT_POWERBOOK because its needed on Appl=
e Laptops.
Maybe USB_HIDINPUT_APPLELAPTOPS or something like this. Is a renaming patch=
 for this welcome?

Thanks for your answer/applying.:)

--=20
No=C3=A8l K=C3=B6the <noel debian.org>
Debian GNU/Linux, www.debian.org
[ message continues ]

al keys"

Hi,


The problem here is backwards compatibility - if we would like to do the=20
change in a consistent way, we should rename all the places which (for=20
historic reasons) mention powerbook only. Unfortunately this would also=20
require renaming the module parameter hid_pb_fnmode, which might be a=20
little too intrusive with respect to maintaining backward compatibility in=
=20
userspace (ok, we have already been fiddling with this parameter anyway=20
during the usbhid code split, but anyway).

If you would care to make the patch which maintains backwards=20
compatibility (for example by aliasing the variable pb_fnmode behing two=20
module parameters), that might probably be ok.

Thanks,

--=20
Jiri Kosina
[ message continues ]

Am Donnerstag, den 03.05.2007, 09:56 +0200 schrieb Jiri Kosina:


Great thanks. Does this mean it will go into your tree and then into the

I understand. I will try.

--=20
No=C3=A8l K=C3=B6the <noel debian.org>
Debian GNU/Linux, www.debian.org
[ message continues ]

No further steps needed on your side. Applied, thanks,

--=20
Jiri Kosina
[ message continues ]