Home » Mailing list archives » linux-kernel » 2007 » May » 7

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roman Zippel
Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
Date: Monday, May 7, 2007 - 10:07 am

Hi,

On Mon, 7 May 2007, Krzysztof Halasa wrote:


So it's not simple library code, or is it?


Normal dependencies, you basically have to manually make sure they are 
correct (and it seems with your patch they aren't). Again, _please_ (with 
sugar on top) don't use select unless you have a good reason for it.

bye, Roman
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Sun May 6, 4:46 pm)
[PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select", Krzysztof Halasa, (Sun May 6, 5:06 pm)
[PATCH 2/3] ARM: include IXP4xx "fuses" support, Krzysztof Halasa, (Sun May 6, 5:07 pm)
[PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Sun May 6, 5:07 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Roman Zippel, (Sun May 6, 6:44 pm)
Re: [PATCH 2/3] ARM: include IXP4xx "fuses" support, Alexey Zaytsev, (Sun May 6, 10:24 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Krzysztof Halasa, (Mon May 7, 2:35 am)
Re: [PATCH 2/3] ARM: include IXP4xx "fuses" support, Krzysztof Halasa, (Mon May 7, 3:24 am)
[PATCH 2a/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 3:27 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Roman Zippel, (Mon May 7, 4:22 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Krzysztof Halasa, (Mon May 7, 4:56 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Michael-Luke Jones, (Mon May 7, 5:59 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Roman Zippel, (Mon May 7, 6:17 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Jeff Garzik, (Mon May 7, 6:21 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Roman Zippel, (Mon May 7, 6:46 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Krzysztof Halasa, (Mon May 7, 9:50 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Roman Zippel, (Mon May 7, 10:07 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 10:12 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Christian Hohnstaedt, (Mon May 7, 10:52 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Michael-Luke Jones, (Mon May 7, 11:14 am)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Satyam Sharma, (Mon May 7, 11:15 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 12:57 pm)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 1:00 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Jeff Garzik, (Mon May 7, 1:31 pm)
Re: [PATCH 0/3] Intel IXP4xx network drivers, Leon Woestenberg, (Mon May 7, 1:39 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Satyam Sharma, (Mon May 7, 1:49 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Randy Dunlap, (Mon May 7, 1:50 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Krzysztof Halasa, (Mon May 7, 1:54 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Roman Zippel, (Mon May 7, 1:57 pm)
[PATCH] Use menuconfig objects II - netdev/wan, Krzysztof Halasa, (Mon May 7, 2:02 pm)
[PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select", Krzysztof Halasa, (Mon May 7, 2:08 pm)
Re: [PATCH 0/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 2:21 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Satyam Sharma, (Mon May 7, 3:39 pm)
Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to " ..., Randy Dunlap, (Mon May 7, 3:52 pm)
[PATCH] Intel IXP4xx network drivers v.2, Krzysztof Halasa, (Mon May 7, 5:11 pm)
[PATCH] Intel IXP4xx network drivers v.2 - NPE, Krzysztof Halasa, (Mon May 7, 5:36 pm)
[PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Mon May 7, 5:46 pm)
[PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS, Krzysztof Halasa, (Mon May 7, 6:19 pm)
Re: [PATCH 0/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 6:40 pm)
Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet an ..., Jeff Garzik, (Mon May 7, 10:28 pm)
Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE, Michael-Luke Jones, (Tue May 8, 12:02 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Michael-Luke Jones, (Tue May 8, 12:05 am)
Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet an ..., Michael-Luke Jones, (Tue May 8, 12:22 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Tue May 8, 4:32 am)
Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet an ..., Lennert Buytenhek, (Tue May 8, 4:37 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Lennert Buytenhek, (Tue May 8, 4:40 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Lennert Buytenhek, (Tue May 8, 4:48 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Alexey Zaytsev, (Tue May 8, 5:47 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Tue May 8, 5:59 am)
Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Tue May 8, 6:47 am)
Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE, Krzysztof Halasa, (Tue May 8, 6:56 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Tue May 8, 6:57 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Tue May 8, 7:12 am)
Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet an ..., Krzysztof Halasa, (Tue May 8, 7:31 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Tue May 8, 7:40 am)
Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet an ..., Lennert Buytenhek, (Tue May 8, 7:53 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Tue May 8, 9:59 am)
Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet an ..., Krzysztof Halasa, (Tue May 8, 10:17 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Wed May 9, 3:21 am)
Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Thu May 10, 7:08 am)