Re: [PATCH 3/3] Intel IXP4xx network drivers

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Michael-Luke Jones <mlj28@...>

To: Krzysztof Halasa <khc@...>

Cc: Jeff Garzik <jeff@...>, Russell King <rmk@...>, lkml <linux-kernel@...>, <netdev@...>, <linux-arm-kernel@...>

Subject: Re: [PATCH 3/3] Intel IXP4xx network drivers

Date: Monday, May 7, 2007 - 8:59 am

On 7 May 2007, at 01:07, Krzysztof Halasa wrote:

quoted text> Adds IXP4xx drivers for built-in CPU components:
> - hardware queue manager
> - NPE (network coprocessors),
> - Ethernet ports,
> - HSS (sync serial) ports (currently only non-channelized HDLC).
>
> Both Ethernet and HSS drivers use queue manager and NPE driver and
> require external firmware file(s) available from www.intel.com.
>
> "Platform device" definitions for Ethernet ports on IXDP425  
> development
> platform are provided (though it has been tested on not yet available
> IXP425-based hardware only)
>
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>

Immediate comments as follows:

(Krzysztof has already seen them in a private email but I'm putting  
them out so people can publically disagree with me if I have got this  
wrong.)

Code placement:
Queue Manager & NPE code => arch/arm/mach-ixp4xx
WAN driver code => drivers/net/wan
Eth code => drivers/net/arm

Kconfig:
I'm not convinced about 'config IXP4XX_NETDEVICES'. I'd lose it  
together with the drivers/net/ixp4xx directory
Ethernet & HSS code should probably select NPE and QMGR (rather than  
depend) but these options should still be exposed in arch/arm/mach- 
ixp4xx/Kconfig

Michael-Luke Jones

PS: Please cc me on replies as I only subscribe to l-a-k.
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Sun May 6, 7:46 pm)

Re: [PATCH 0/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 9:40 pm)

Re: [PATCH 0/3] Intel IXP4xx network drivers, Leon Woestenberg, (Mon May 7, 4:39 pm)

Re: [PATCH 0/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 5:21 pm)

[PATCH 2a/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 6:27 am)

[PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Sun May 6, 8:07 pm)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Lennert Buytenhek, (Tue May 8, 7:40 am)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Michael-Luke Jones, (Mon May 7, 8:59 am)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 1:12 pm)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Michael-Luke Jones, (Mon May 7, 2:14 pm)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 3:57 pm)

[PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS, Krzysztof Halasa, (Mon May 7, 9:19 pm)

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and ..., Lennert Buytenhek, (Tue May 8, 7:37 am)

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and ..., Krzysztof Halasa, (Tue May 8, 10:31 am)

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and ..., Lennert Buytenhek, (Tue May 8, 10:53 am)

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and ..., Krzysztof Halasa, (Tue May 8, 1:17 pm)

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and ..., Michael-Luke Jones, (Tue May 8, 3:22 am)

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and ..., Jeff Garzik, (Tue May 8, 1:28 am)

[PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Mon May 7, 8:46 pm)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Tue May 8, 7:32 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Tue May 8, 10:12 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Tue May 8, 10:40 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Tue May 8, 12:59 pm)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Wed May 9, 6:21 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Thu May 10, 10:08 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Alexey Zaytsev, (Tue May 8, 8:47 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Lennert Buytenhek, (Tue May 8, 8:59 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Michael-Luke Jones, (Tue May 8, 3:05 am)

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR, Krzysztof Halasa, (Tue May 8, 9:57 am)

[PATCH] Intel IXP4xx network drivers v.2 - NPE, Krzysztof Halasa, (Mon May 7, 8:36 pm)

Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE, Michael-Luke Jones, (Tue May 8, 3:02 am)

Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE, Krzysztof Halasa, (Tue May 8, 9:56 am)

[PATCH] Intel IXP4xx network drivers v.2, Krzysztof Halasa, (Mon May 7, 8:11 pm)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Christian Hohnstaedt, (Mon May 7, 1:52 pm)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Mon May 7, 4:00 pm)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Lennert Buytenhek, (Tue May 8, 7:48 am)

Re: [PATCH 3/3] Intel IXP4xx network drivers, Krzysztof Halasa, (Tue May 8, 9:47 am)

[PATCH 2/3] ARM: include IXP4xx "fuses" support, Krzysztof Halasa, (Sun May 6, 8:07 pm)

Re: [PATCH 2/3] ARM: include IXP4xx "fuses" support, Alexey Zaytsev, (Mon May 7, 1:24 am)

Re: [PATCH 2/3] ARM: include IXP4xx "fuses" support, Krzysztof Halasa, (Mon May 7, 6:24 am)

[PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select", Krzysztof Halasa, (Sun May 6, 8:06 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Roman Zippel, (Sun May 6, 9:44 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Krzysztof Halasa, (Mon May 7, 5:35 am)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Roman Zippel, (Mon May 7, 7:22 am)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Krzysztof Halasa, (Mon May 7, 7:56 am)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Roman Zippel, (Mon May 7, 9:17 am)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Jeff Garzik, (Mon May 7, 9:21 am)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Roman Zippel, (Mon May 7, 9:46 am)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Krzysztof Halasa, (Mon May 7, 12:50 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Roman Zippel, (Mon May 7, 1:07 pm)

[PATCH 1a/3] WAN Kconfig: change "depends on HDLC" to "select", Krzysztof Halasa, (Mon May 7, 5:08 pm)

[PATCH] Use menuconfig objects II - netdev/wan, Krzysztof Halasa, (Mon May 7, 5:02 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Krzysztof Halasa, (Mon May 7, 4:54 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Satyam Sharma, (Mon May 7, 2:15 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Jeff Garzik, (Mon May 7, 4:31 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Roman Zippel, (Mon May 7, 4:57 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Satyam Sharma, (Mon May 7, 4:49 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Randy Dunlap, (Mon May 7, 4:50 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Satyam Sharma, (Mon May 7, 6:39 pm)

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "se..., Randy Dunlap, (Mon May 7, 6:52 pm)

Navigation

Popular discussions


linux-kernel:
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Linus Torvalds	Linux 2.6.21-rc1
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
pageexec	Re: [stable] Linux 2.6.25.10
linux-netdev:
Linus Torvalds	Re: [GIT]: Networking
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Natalie Protasevich	[BUG] New Kernel Bugs
Jarek Poplawski	[PATCH take 2] pkt_sched: Protect gen estimators under est_lock.
git:

openmoko-community:

Colocation donated by:

Online users

Syndicate