On Wed, 2 May 2007, No?l K=F6the wrote:

quoted text
> The description of this option needs to be extended to be correct:)
> --- /usr/src/linux-2.6.21/drivers/usb/input/Kconfig     2007-04-27 18:02:=
46.000000000 +0200
quoted text
> +++ Kconfig.new 2007-05-02 16:47:56.000000000 +0200
> @@ -28,12 +28,12 @@
>         depends on USB_HID && INPUT=3Dn
> =20
>  config USB_HIDINPUT_POWERBOOK
> -       bool "Enable support for iBook/PowerBook special keys"
> +       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro speci=
al keys"

Hi,

I will apply this into my tree, thanks.

quoted text
> This option is needed on the Apple Intel Laptops, too. I would suggest=20
> to rename USB_HIDINPUT_POWERBOOK because its needed on Apple Laptops.=20
> Maybe USB_HIDINPUT_APPLELAPTOPS or something like this. Is a renaming=20
> patch for this welcome?

The problem here is backwards compatibility - if we would like to do the=20
change in a consistent way, we should rename all the places which (for=20
historic reasons) mention powerbook only. Unfortunately this would also=20
require renaming the module parameter hid_pb_fnmode, which might be a=20
little too intrusive with respect to maintaining backward compatibility in=
=20
userspace (ok, we have already been fiddling with this parameter anyway=20
during the usbhid code split, but anyway).

If you would care to make the patch which maintains backwards=20
compatibility (for example by aliasing the variable pb_fnmode behing two=20
module parameters), that might probably be ok.

Thanks,

--=20
Jiri Kosina