Re: tty-related oops in latest kernel(s)?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Tero Roponen <teanropo@...>
Cc: <linux-kernel@...>, <akpm@...>, Alan Cox <alan@...>, Andy Whitcroft <apw@...>
Date: Tuesday, May 29, 2007 - 2:57 pm

Hi Tero,

On 5/29/07, Tero Roponen <teanropo@jyu.fi> wrote:

Well, I went through all tty related patches that went in after 2.6.21
and didn't really find anything interesting, except this:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=543691...

But it does seem correct. You could try reverting that from 2.6.22-rc3
and see if you can trigger the bug.

Looking at the original report again:


So tty from filp->private_data does not match
tty->driver->ttys[tty->index] and release_dev bails out (thus messing
up reference count).


Presumably someone tries to close the file again which is why we get a
new complaint that reference counting has gone bad.

Unfortunately, I have no idea why drivers->tty does not match. It
could be a race with release_tty() or real use-after-free but I am
unable to find anything obvious in 2.6.21 -> 2.6.22-rc3 that would
break it. Doing the git bisect dance here would really help...
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
tty-related oops in latest kernel(s)?, Tero Roponen, (Sun May 27, 5:06 am)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Mon May 28, 3:22 am)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Mon May 28, 5:34 am)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Tue May 29, 12:04 pm)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Tue May 29, 2:57 pm)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Tue May 29, 11:57 pm)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Wed May 30, 1:54 am)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Wed May 30, 8:02 am)
Re: tty-related oops in latest kernel(s)?, Andrew Morton, (Wed May 30, 11:39 am)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Wed May 30, 12:01 pm)
Re: tty-related oops in latest kernel(s)?, Antonino A. Daplas, (Wed May 30, 7:17 pm)
Re: tty-related oops in latest kernel(s)?, Antonino A. Daplas, (Wed May 30, 6:14 pm)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Wed May 30, 2:13 pm)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Wed May 30, 2:27 pm)
Re: tty-related oops in latest kernel(s)?, Andrew Morton, (Wed May 30, 12:09 pm)
Re: tty-related oops in latest kernel(s)?, Alexey Dobriyan, (Wed May 30, 2:04 pm)
Re: tty-related oops in latest kernel(s)?, Antonino A. Daplas, (Wed May 30, 7:14 pm)
Re: [Linux-fbdev-devel] tty-related oops in latest kernel(s)?, Geert Uytterhoeven, (Thu May 31, 3:17 am)
Re: [Linux-fbdev-devel] tty-related oops in latest kernel(s)?, Antonino A. Daplas, (Thu May 31, 5:04 am)
Re: tty-related oops in latest kernel(s)?, David Miller, (Wed May 30, 7:18 pm)
Re: tty-related oops in latest kernel(s)?, Antonino A. Daplas, (Wed May 30, 7:28 pm)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Wed May 30, 2:00 am)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Wed May 30, 1:59 am)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Tue May 29, 11:43 pm)
Re: tty-related oops in latest kernel(s)?, Tero Roponen, (Mon May 28, 4:08 am)
Re: tty-related oops in latest kernel(s)?, Pekka Enberg, (Mon May 28, 3:47 am)