Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Garrett <mjg59@...>
Cc: Rafael J. Wysocki <rjw@...>, pm list <linux-pm@...>, LKML <linux-kernel@...>, Nigel Cunningham <nigel@...>, Pavel Machek <pavel@...>, Oliver Neukum <oliver@...>
Date: Monday, May 28, 2007 - 12:09 pm

On Sun, 27 May 2007, Matthew Garrett wrote:


I can't speak for the second example, but there's a good reason the
first example works this way.  It's not a matter of races; the problem
is that the kernel thread's job is to selectively suspend and resume
devices.  We don't want it doing this while a system sleep is in 
progress; it would (and in fact has, before the thread was made 
freezable) cause the sleep transition to abort.

Handling it entirely from within the drivers is possible in theory.  
Unfortunately the design of the PM core has not leant itself to such an 
approach.  Using separate callbacks for hibernation vs. STR will help, 
as will Raphael's notifiers.

Alan Stern

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH -mm 0/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Sun May 27, 4:29 pm)
[RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hi..., Rafael J. Wysocki, (Sun May 27, 4:31 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 1:43 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 3:43 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 7:38 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 8:26 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 9:10 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 7:28 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 4:48 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 6:41 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 6:26 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 8:07 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Sun May 27, 6:01 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Sun May 27, 5:45 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 7:22 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Alan Stern, (Mon May 28, 12:09 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 3:44 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Sun May 27, 4:45 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Sun May 27, 5:55 pm)
[RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Sun May 27, 4:30 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Tue May 29, 6:24 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 4:44 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 5:11 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 1:42 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 1:44 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 4:02 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Mon May 28, 1:29 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Mon May 28, 1:26 pm)
[RFC][PATCH -mm 2/3] PM: Disable usermode helper before hibe..., Rafael J. Wysocki, (Sun May 27, 4:30 pm)