Re: b44: regression in 2.6.22 (resend)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Michael Buesch
Date: Monday, May 28, 2007 - 3:49 am

Can you also test the following patch?
I think there's a bug in b44 that is doesn't properly discard
shared IRQs, so it might possibly generate a NAPI storm, dunno.
Worth a try.

Index: linux-2.6.22-rc3/drivers/net/b44.c
===================================================================
--- linux-2.6.22-rc3.orig/drivers/net/b44.c	2007-05-27 23:01:44.000000000 +0200
+++ linux-2.6.22-rc3/drivers/net/b44.c	2007-05-28 12:48:27.000000000 +0200
@@ -911,6 +911,8 @@ static irqreturn_t b44_interrupt(int irq
 	spin_lock(&bp->lock);
 
 	istat = br32(bp, B44_ISTAT);
+	if (istat == 0xFFFFFFFF)
+		goto out; /* Shared IRQ not for us */
 	imask = br32(bp, B44_IMASK);
 
 	/* The interrupt mask register controls which interrupt bits
@@ -942,6 +944,7 @@ irq_ack:
 		bw32(bp, B44_ISTAT, istat);
 		br32(bp, B44_ISTAT);
 	}
+out:
 	spin_unlock(&bp->lock);
 	return IRQ_RETVAL(handled);
 }


-- 
Greetings Michael.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun May 27, 12:25 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Sun May 27, 12:45 pm)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun May 27, 1:36 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Sun May 27, 1:46 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Sun May 27, 2:13 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Sun May 27, 2:16 pm)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun May 27, 2:46 pm)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun May 27, 2:50 pm)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun May 27, 3:15 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Sun May 27, 5:24 pm)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun May 27, 5:40 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Mon May 28, 3:16 am)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Mon May 28, 3:49 am)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Mon May 28, 7:09 am)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Mon May 28, 7:12 am)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Mon May 28, 7:55 am)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Mon May 28, 8:14 am)
Re: b44: regression in 2.6.22 (resend), Thomas Gleixner, (Mon May 28, 8:32 am)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Mon May 28, 8:43 am)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Mon May 28, 10:44 am)
Re: b44: regression in 2.6.22 (resend), Thomas Gleixner, (Mon May 28, 12:23 pm)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Mon May 28, 1:55 pm)
Re: b44: regression in 2.6.22 (resend), Thomas Gleixner, (Mon May 28, 2:45 pm)
Re: b44: regression in 2.6.22 (resend), Gary Zambrano, (Tue May 29, 6:58 am)
Re: b44: regression in 2.6.22 (resend), Gary Zambrano, (Tue May 29, 7:14 am)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Tue May 29, 10:23 am)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Tue May 29, 11:28 am)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Tue May 29, 1:45 pm)
Re: b44: regression in 2.6.22 (resend), Stephen Hemminger, (Tue May 29, 2:01 pm)
Re: b44: regression in 2.6.22 (resend), Gary Zambrano, (Tue May 29, 2:05 pm)
Re: b44: regression in 2.6.22 (resend), Gary Zambrano, (Tue May 29, 2:36 pm)
Re: b44: regression in 2.6.22 (resend), Jeff Garzik, (Tue May 29, 3:39 pm)
Re: b44: regression in 2.6.22 (resend), Michael Buesch, (Wed May 30, 3:45 am)
Re: b44: regression in 2.6.22 (resend), Maximilian Engelhardt, (Sun Jun 3, 9:26 am)
Re: b44: regression in 2.6.22 (resend), Thomas Gleixner, (Sun Jun 3, 11:39 pm)
Re: b44: regression in 2.6.22 (resend), Stephen Hemminger, (Mon Jun 4, 9:09 am)
Re: b44: regression in 2.6.22 (resend), Thomas Gleixner, (Mon Jun 4, 9:35 am)
iperf: performance regression (was b44 driver problem?), Stephen Hemminger, (Mon Jun 4, 9:59 am)
Re: iperf: performance regression (was b44 driver problem?), Thomas Gleixner, (Mon Jun 4, 10:32 am)
Re: iperf: performance regression (was b44 driver problem?), Stephen Hemminger, (Mon Jun 4, 10:51 am)
Re: iperf: performance regression (was b44 driver problem?), Thomas Gleixner, (Mon Jun 4, 12:00 pm)
Re: iperf: performance regression (was b44 driver problem?), Thomas Gleixner, (Mon Jun 4, 12:26 pm)
Re: iperf: performance regression (was b44 driver problem?), Maximilian Engelhardt, (Mon Jun 4, 12:47 pm)
Re: iperf: performance regression (was b44 driver problem?), Stephen Hemminger, (Mon Jun 4, 1:02 pm)
Re: iperf: performance regression (was b44 driver problem?), Maximilian Engelhardt, (Mon Jun 4, 1:52 pm)