Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Garrett <mjg59@...>
Cc: pm list <linux-pm@...>, LKML <linux-kernel@...>, Nigel Cunningham <nigel@...>, Pavel Machek <pavel@...>, Alan Stern <stern@...>, Oliver Neukum <oliver@...>
Date: Monday, May 28, 2007 - 3:44 am

On Monday, 28 May 2007 00:01, Matthew Garrett wrote:

Or worse.  Suppose, for example, that the device which needs the firmware
uploaded is your network adapter and the firmware file is on NFS.

I don't think there's a solution to the "requesting firmware from .resume()"
problem other than copying the firmware into memory _before_ the suspend
and using this copy to upload the firmware in .resume().


Yes.


That's true, but we've been using the freezer for so long that at least some
drivers started to rely on it being used.  That's the reason, IMO, why we can't
just drop the freezer right now.

It can be _replaced_ by some other synchronization mechanisms, but not just
dropped.  Moreover, I think that to implement such mechanisms within device
drivers we should first stop using the same .suspend() and .resume() routines
for both hibernation and suspend.

This is the plan right now (ie. to stop using .suspend() and .resume() for
hibernation) and when we're done with that (yes, it'll take some time), then we
can think of dropping the freezer entirely from the suspend code path.


Well, I don't think we're breaking the drivers.


Please consider the example with a firmware on NFS. :-)

I think the _solution_ would be to fix the drivers.  The other approaches are
just workarounds, including the $subject patch.

Greetings,
Rafael
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH -mm 0/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Sun May 27, 4:29 pm)
[RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hi..., Rafael J. Wysocki, (Sun May 27, 4:31 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 1:43 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 3:43 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 7:38 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 8:26 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 9:10 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 7:28 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 4:48 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 6:41 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 6:26 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Mon May 28, 8:07 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Sun May 27, 6:01 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Sun May 27, 5:45 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 7:22 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Mon May 28, 3:44 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Michael-Luke Jones, (Sun May 27, 4:45 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware befor..., Rafael J. Wysocki, (Sun May 27, 5:55 pm)
[RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Sun May 27, 4:30 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Tue May 29, 6:24 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 4:44 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 5:11 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 1:42 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 1:44 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 4:02 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Mon May 28, 1:29 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Mon May 28, 1:26 pm)
[RFC][PATCH -mm 2/3] PM: Disable usermode helper before hibe..., Rafael J. Wysocki, (Sun May 27, 4:30 pm)