Home » Mailing list archives » linux-kernel » 2007 » May » 21

[PATCH] ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel, amendment

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stefan Richter
Subject: [PATCH] ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel, amendment
Date: Monday, May 21, 2007 - 9:52 am

Pointed out by Arnd Bergmann:  PPC32 aligns this at 64bit, IA32 packs
it.  A kernel-wide available __compat_u64 which is 4-byte aligned on
AMD64 and IA64 would be nicer though.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/ieee1394/raw1394.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Index: linux/drivers/ieee1394/raw1394.c
===================================================================
--- linux.orig/drivers/ieee1394/raw1394.c
+++ linux/drivers/ieee1394/raw1394.c
@@ -2814,7 +2814,11 @@ struct raw1394_iso_packets32 {
 struct raw1394_cycle_timer32 {
         __u32 cycle_timer;
         __u64 local_time;
-} __attribute__((packed));
+}
+#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
+__attribute__((packed))
+#endif
+;
 
 #define RAW1394_IOC_ISO_RECV_PACKETS32          \
         _IOW ('#', 0x25, struct raw1394_iso_packets32)

-- 
Stefan Richter
-=====-=-=== -=-= =-=-=
http://arcgraph.de/sr/

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix/add raw1394 CONFIG_COMPAT code, Petr Vandrovec, (Sun May 6, 7:14 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Mon May 7, 9:40 am)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Dan Dennedy, (Mon May 14, 8:52 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Tue May 15, 3:59 pm)
[PATCH 1/3] ieee1394: raw1394: Fix read() for 32bit userla ..., Stefan Richter, (Tue May 15, 4:00 pm)
[PATCH 2/3] ieee1394: raw1394: Fix write() for 32bit userl ..., Stefan Richter, (Tue May 15, 4:01 pm)
[PATCH 3/3] ieee1394: raw1394: Add ioctl() for 32bit userl ..., Stefan Richter, (Tue May 15, 4:02 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Petr Vandrovec, (Tue May 15, 4:51 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Arnd Bergmann, (Sat May 19, 4:55 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Sat May 19, 5:02 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Arnd Bergmann, (Sun May 20, 8:03 am)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Sun May 20, 8:28 am)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Arnd Bergmann, (Sun May 20, 8:37 am)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Sun May 20, 8:55 am)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Mon May 21, 12:28 am)
[PATCH] ieee1394: raw1394: Add ioctl() for 32bit userland ..., Stefan Richter, (Mon May 21, 9:52 am)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Dan Dennedy, (Tue May 22, 9:54 pm)
Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code, Stefan Richter, (Tue May 22, 11:32 pm)