login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
May
»
21
Re: [PATCH] 2.6.21: nfs_readpages: Add missing braces
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Trond Myklebust
Subject:
Re: [PATCH] 2.6.21: nfs_readpages: Add missing braces
Date: Monday, May 21, 2007 - 6:24 am
On Mon, 2007-05-21 at 14:09 +0100, Maciej W. Rozycki wrote:
quoted text
> A change a while ago added a call to gather statistics to a conditional > statement, but braces were missed on that occasion resulting in a change > of semanticts. This a change to rectify.
So you are proposing this as a stable update? It won't apply on 2.6.22-rc2. Cheers Trond
quoted text
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> > --- > It should be obvious -- please apply. > > Maciej > > patch-mips-2.6.18-20060920-nfs_readpages-0 > diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/fs/nfs/read.c linux-mips-2.6.18-20060920/fs/nfs/read.c > --- linux-mips-2.6.18-20060920.macro/fs/nfs/read.c 2006-09-20 14:20:24.000000000 +0000 > +++ linux-mips-2.6.18-20060920/fs/nfs/read.c 2007-05-20 15:01:31.000000000 +0000 > @@ -696,9 +696,10 @@ int nfs_readpages(struct file *filp, str > ret = read_cache_pages(mapping, pages, readpage_async_filler, &desc); > if (!list_empty(&head)) { > int err = nfs_pagein_list(&head, server->rpages); > - if (!ret) > + if (!ret) { > nfs_add_stats(inode, NFSIOS_READPAGES, err); > ret = err; > + } > } > put_nfs_open_context(desc.ctx); > return ret;
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] 2.6.21: nfs_readpages: Add missing braces
, Maciej W. Rozycki
, (Mon May 21, 6:09 am)
Re: [PATCH] 2.6.21: nfs_readpages: Add missing braces
, Trond Myklebust
, (Mon May 21, 6:24 am)
Re: [PATCH] 2.6.21: nfs_readpages: Add missing braces
, Maciej W. Rozycki
, (Mon May 21, 7:07 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Eric Sandeen
Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages
Daniel Hazelton
Re: x86: 4kstacks default
stephane eranian
Re: perf_counters issue with PERF_SAMPLE_GROUP
Mathieu Desnoyers
Re: Linux 2.6.25-rc2
Greg Kroah-Hartman
[PATCH 01/75] platform: prefix MODALIAS with "platform:"
git
:
Johannes Schindelin
[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Alex Riesen
Re: git exclude patterns for directory
Andreas Ericsson
Re: why not TortoiseGit
Jeff King
Re: warning: too many files, skipping inexact rename detection
Teemu Likonen
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
linux-netdev
:
Andi Kleen
Re: RFC: Nagle latency tuning
Herbert Xu
Re: Oops in tun: bisected to Limit amount of queued packets per device
gregkh
Patch "IPv6: keep route for tentative address" has been added to the 2.6.34-stable...
Patrick McHardy
Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
Paul Gortmaker
[PATCH net-next 09/16] tipc: Relocate trivial link status functions to header file
git-commits-head
:
Linux Kernel Mailing List
sh: Fix compile error by operands(mov.l) in sh3/entry.S
Linux Kernel Mailing List
New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List
tmpfs: depend on shmem
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Linux Kernel Mailing List
Staging: et131x: prune all the debug code
openbsd-misc
:
Andres Salazar
About priorities in /etc/resolv.conf
Tonnerre LOMBARD
Re: bge0: watchdog timeout
Damien Miller
Re: Patching a SSH 'Weakness'
ropers
Re: Real men don't attack straw men
Stuart Henderson
Re: Apache Seg Fault after upgrade to 4.6 stable
Colocation donated by:
Syndicate