[PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrea Righi
Date: Saturday, May 19, 2007 - 3:33 am

Bernd Eckenfels wrote:

Depends on print_fatal_signals patch.

---

Limit the rate of print_fatal_signal() to avoid potential denial-of-service
attacks.

Signed-off-by: Andrea Righi <a.righi@cineca.it>

diff -urpN linux-2.6.22-rc1-mm1/kernel/signal.c linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c
--- linux-2.6.22-rc1-mm1/kernel/signal.c	2007-05-19 11:25:24.000000000 +0200
+++ linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c	2007-05-19 11:30:00.000000000 +0200
@@ -790,7 +790,10 @@ static void print_vmas(void)
 
 static void print_fatal_signal(struct pt_regs *regs, int signr)
 {
-	printk("%s/%d: potentially unexpected fatal signal %d.\n",
+	if (unlikely(!printk_ratelimit()))
+		return;
+
+	printk(KERN_WARNING "%s/%d: potentially unexpected fatal signal %d.\n",
 		current->comm, current->pid, signr);
 
 #ifdef __i386__
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] log out-of-virtual-memory events, Andrea Righi, (Thu May 17, 9:24 am)
Re: [RFC] log out-of-virtual-memory events, Rik van Riel, (Thu May 17, 11:22 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Jan Engelhardt, (Thu May 17, 11:28 pm)
Re: [RFC] log out-of-virtual-memory events, Andrea Righi, (Fri May 18, 12:50 am)
Re: [RFC] log out-of-virtual-memory events, Robin Holt, (Fri May 18, 2:16 am)
Re: [RFC] log out-of-virtual-memory events, Andrea Righi, (Fri May 18, 8:55 am)
Re: [RFC] log out-of-virtual-memory events, Andrea Righi, (Fri May 18, 9:05 am)
Re: [RFC] log out-of-virtual-memory events, Bernd Eckenfels, (Fri May 18, 9:34 am)
Re: [RFC] log out-of-virtual-memory events, Bernd Eckenfels, (Fri May 18, 9:36 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Jan Engelhardt, (Sat May 19, 12:46 am)
[PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] lo ..., Andrea Righi, (Sat May 19, 3:33 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sat May 19, 5:14 pm)
Re: [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sat May 19, 5:15 pm)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sun May 20, 4:21 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Stephen Hemminger, (Sun May 20, 9:08 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sun May 20, 9:12 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sun May 20, 1:55 pm)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sun May 20, 2:20 pm)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sun May 20, 2:23 pm)
Re: [PATCH 1/2] limit print_fatal_signal() rate, Andrea Righi, (Mon May 21, 3:44 am)
Re: [PATCH 2/2] log out-of-virtual-memory events, Andrea Righi, (Mon May 21, 3:48 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Mon May 21, 4:04 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Gábor Lénárt, (Mon May 21, 4:26 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Mon May 21, 5:47 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Mon May 21, 11:59 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Wed May 23, 11:45 am)
Re: [PATCH 1/2] limit print_fatal_signal() rate, Andrea Righi, (Thu May 24, 1:50 am)
Re: [PATCH 1/2] limit print_fatal_signal() rate, Ingo Molnar, (Thu May 24, 2:58 am)
Re: signals logged / [RFC] log out-of-virtual-memory events, Folkert van Heusden, (Sun Jun 10, 12:53 pm)