Re: [RFC] select and dependencies in Kconfig

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Russell King
Date: Wednesday, May 16, 2007 - 1:38 am

On Wed, May 16, 2007 at 04:33:35AM +0100, Al Viro wrote:

We first need to ensure that we don't have any cases which explore the
current behaviour.  I wonder how the following will be interpreted with
the ARCH_IXP4XX=y and ARCH_IXP4XX=n cases:

arch/arm/common/Kconfig:config SA1111
arch/arm/common/Kconfig:        bool
arch/arm/common/Kconfig:        select DMABOUNCE
arch/arm/common/Kconfig:
arch/arm/common/Kconfig:config DMABOUNCE
arch/arm/common/Kconfig:        bool

arch/arm/mach-ixp4xx/Kconfig:if ARCH_IXP4XX
arch/arm/mach-ixp4xx/Kconfig:
...
arch/arm/mach-ixp4xx/Kconfig:config DMABOUNCE
arch/arm/mach-ixp4xx/Kconfig-   bool
arch/arm/mach-ixp4xx/Kconfig-   default y
arch/arm/mach-ixp4xx/Kconfig-   depends on PCI
...
arch/arm/mach-ixp4xx/Kconfig:endif


We also have:

arch/arm/mm/Kconfig:config CPU_32v6K
arch/arm/mm/Kconfig-    bool "Support ARM V6K processor extensions" if !SMP
arch/arm/mm/Kconfig-    depends on CPU_V6
arch/arm/mm/Kconfig-    default y if SMP

which gives: option available on V6 CPUs, user selectable on V6 UP, always
selected on V6 SMP.

and:

arch/arm/mm/Kconfig:config CPU_V7
arch/arm/mm/Kconfig:    bool "Support ARM V7 processor"
arch/arm/mm/Kconfig:    depends on ARCH_INTEGRATOR
arch/arm/mm/Kconfig:    select CPU_32v6K

It would be undesirable for CPU_V7 to depend on CPU_V6 being set.  (V7
always has V6K.)  I guess V6K would have to become:

config CPU_32v6K
	bool "Support ARM V6K processor extensions" if !SMP && !CPU_V7
	depends on CPU_V6 || CPU_V7
	default y if SMP || CPU_V7

and the select statement removed from CPU_V7.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] select and dependencies in Kconfig, Al Viro, (Tue May 15, 8:33 pm)
Re: [RFC] select and dependencies in Kconfig, Linus Torvalds, (Tue May 15, 8:48 pm)
Re: [RFC] select and dependencies in Kconfig, Russell King, (Wed May 16, 1:38 am)
Re: [RFC] select and dependencies in Kconfig, Satyam Sharma, (Wed May 16, 7:20 am)
Re: [RFC] select and dependencies in Kconfig, Stefan Richter, (Wed May 16, 7:24 am)
Re: [RFC] select and dependencies in Kconfig, Satyam Sharma, (Wed May 16, 8:31 am)
Re: [RFC] select and dependencies in Kconfig, Timur Tabi, (Wed May 16, 4:30 pm)
Re: [RFC] select and dependencies in Kconfig, Stefan Richter, (Wed May 16, 5:16 pm)
Re: [RFC] select and dependencies in Kconfig, Stefan Richter, (Wed May 16, 5:32 pm)
Re: [RFC] select and dependencies in Kconfig, Roman Zippel, (Thu May 17, 8:38 pm)