Hi Davide,

On Mon, 2 Apr 2007, Davide Libenzi wrote:
quoted text
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6.21-rc5.fds/fs/signalfd.c	2007-04-02 15:06:29.000000000 -0700

quoted text
> +/*
> + * Copied from copy_siginfo_to_user() in kernel/signal.c
> + */
> +static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo,
> +			     siginfo_t const *kinfo)
> +{
> +	long err;
> +
> +	BUILD_BUG_ON(sizeof(struct signalfd_siginfo) != 128);
> +
> +	/*
> +	 * Unused memebers should be zero ...
> +	 */
> +	err = __clear_user(uinfo, sizeof(*uinfo));
              ^^^^^^^^^^^^

Shouldn't this be `clear_user()'? I don't see any access_ok() calls
before this call (I do see them in copy_siginfo_to_user() in
kernel/signal.c), but of course I may miss something...

I only noticed because m68k doesn't have __clear_user(), as this routine
was never needed by generic code before your change.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/