Re: [PATCH] console UTF-8 fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Egmont Koblinger
Date: Saturday, April 7, 2007 - 10:26 am

On Sat, Apr 07, 2007 at 01:00:48PM +0200, Jan Engelhardt wrote:

Hi,


No dot, I'm already convinced. To clarify the inverse thingy:

This is what the current kernel does:
  1) tries to display the desired symbol
  2) if it fails, tries to display U+FFFD (which usually looks similar to an
     inverted question mark)
  3) if this fails again then displays a normal '?'
     (or a different symbol due to a bug discussed below)

Here's my proposal. This only alters the 3rd step, not the first two:
  1) tries to display the desired symbol
  2) if it fails, tries to display U+FFFD, still with _normal_ attributes
  3) if this fails then display an ascii '?' with inverted attributes

So you won't get "double" inversion. If you do have U+FFFD in your font then
this will introduce no chance. If you don't have U+FFFD, you'll see inverse
question marks instead of normal ones.



There's nothing wrong with my latin2 unicode map, and I've located and
changed the part _in the kernel_ that displays a false glyph using the
algorithm I've outlined. It just uses "the glyph at that code position
within the glyph table" as a fallback, which might be okay in 8-bit mode
(and I haven't modified the behavior in that case), but I got rid of this
behavior in UTF-8 mode since it's definitely a fault in the world of
Unicode.


I rather think it should display U+FFFD but YMMV.


This is not the character I've been talking about, I actually _did_ talk
about u with double acute accent (ű - you might not have seen this character
so far, AFAIK it's only used in Hungarian, no other languages). But we agree
that the kernel definitely shouldn't display a character with a different
accent on it. This is one of the bugs my patch addresses.


bye,

Egmont
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] console UTF-8 fixes, Egmont Koblinger, (Fri Apr 6, 12:12 pm)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Fri Apr 6, 12:43 pm)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Sat Apr 7, 2:24 am)
Re: [PATCH] console UTF-8 fixes, Jan Engelhardt, (Sat Apr 7, 4:00 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Sat Apr 7, 10:26 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Sat Apr 7, 10:59 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Tue Apr 10, 2:43 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Tue Apr 10, 8:43 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Tue Apr 10, 10:19 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Tue Apr 10, 10:30 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Tue Apr 10, 10:36 am)
Re: [PATCH] console UTF-8 fixes, Alan Cox, (Tue Apr 10, 10:36 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Tue Apr 10, 11:51 am)
Re: [PATCH] console UTF-8 fixes, Jan Engelhardt, (Wed Apr 11, 5:58 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Wed Apr 11, 11:28 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Wed Apr 11, 11:36 am)
Re: [PATCH] console UTF-8 fixes, Jan Engelhardt, (Wed Apr 11, 12:00 pm)
Re: [PATCH] console UTF-8 fixes, Pavel Machek, (Wed Apr 11, 12:36 pm)
Re: [PATCH] console UTF-8 fixes, Jan Engelhardt, (Thu Apr 12, 1:14 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 2:11 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 2:22 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 5:54 am)
Re: [PATCH] console UTF-8 fixes, Alan Cox, (Thu Apr 12, 6:13 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 7:06 am)
Re: [PATCH] console UTF-8 fixes, Roman Zippel, (Thu Apr 12, 7:38 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 7:58 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Thu Apr 12, 8:36 am)
Re: [PATCH] console UTF-8 fixes, Roman Zippel, (Thu Apr 12, 8:52 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 9:36 am)
Re: [PATCH] console UTF-8 fixes, Jan Engelhardt, (Thu Apr 12, 9:41 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 9:55 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Thu Apr 12, 9:58 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 10:16 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Thu Apr 12, 10:35 am)
Re: [PATCH] console UTF-8 fixes, Egmont Koblinger, (Thu Apr 12, 10:44 am)
Re: [PATCH] console UTF-8 fixes, H. Peter Anvin, (Thu Apr 12, 10:49 am)
Re: [PATCH] console UTF-8 fixes, Roman Zippel, (Thu Apr 12, 11:09 am)
Re: [PATCH] console UTF-8 fixes, Jan Engelhardt, (Thu Apr 12, 11:46 am)