Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!) | KernelTrap

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Thomas Gleixner <tglx@...>

To: David Brownell <david-b@...>

Cc: Stefan Richter <stefanr@...>, Jan Engelhardt <jengelh@...>, Randy Dunlap <randy.dunlap@...>, Tony Lindgren <tony@...>, <linux-kernel@...>

Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

Date: Friday, April 6, 2007 - 6:17 pm

David,

On Fri, 2007-04-06 at 14:05 -0700, David Brownell wrote:

quoted text

> Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
> Every one of those examples violates that simple rule.
>
> Why does *anyone* have even the slightest difficulty understanding such a
> simple rule? I realize that two of those words have more than a single
> syllable, but that should not be a problem. Even EMACS is trainable.

please stop to be more Catholic than the Pope.

commit 0aa599c5644fddd3052433c5335260108a8a39a2
drivers/usb/net/usbnet.h

http://tglx.de/private/tglx/usbnet.png

/me recommends emacs-develock.el for colorful white space wreckage
display !

You probably want to look at more files contributed by david-b before
you look at mine :)

tglx

-

unsubscribe notice

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 20/90] ARM: OMAP: gpio init section cleanups, Tony Lindgren, (Wed Apr 4, 2:04 pm)

[PATCH 21/90] ARM: OMAP: gpio object shrinkage, cleanup, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 22/90] ARM: OMAP: Fix Amstrad Delta omap-keypad usage, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 23/90] ARM: OMAP: PalmZ71 extra brace fix, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 24/90] ARM: OMAP: Fix typo in gpio, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Dmitry Torokhov, (Wed Apr 4, 4:47 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, David Brownell, (Wed Apr 4, 4:59 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Randy Dunlap, (Wed Apr 4, 3:00 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Jan Engelhardt, (Wed Apr 4, 4:06 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, David Brownell, (Wed Apr 4, 4:51 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Randy Dunlap, (Wed Apr 4, 5:26 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Jan Engelhardt, (Wed Apr 4, 10:15 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Randy Dunlap, (Thu Apr 5, 12:18 am)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, David Brownell, (Thu Apr 5, 2:19 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Jan Engelhardt, (Thu Apr 5, 4:35 pm)

coding style for long conditions (WAS: Re: [PATCH 25/90] ......, David Brownell, (Fri Apr 6, 1:29 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Jan Engelhardt, (Fri Apr 6, 3:16 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., David Brownell, (Fri Apr 6, 4:57 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Jan Engelhardt, (Fri Apr 6, 6:04 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., David Brownell, (Fri Apr 6, 6:40 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Jan Engelhardt, (Fri Apr 6, 7:50 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Stefan Richter, (Fri Apr 6, 3:03 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Scott Preece, (Sun Apr 8, 9:24 am)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., David Brownell, (Fri Apr 6, 5:05 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Thomas Gleixner, (Fri Apr 6, 6:17 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., David Brownell, (Fri Apr 6, 6:57 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Dmitry Torokhov, (Sun Apr 8, 2:19 am)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Thomas Gleixner, (Fri Apr 6, 7:21 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., David Brownell, (Fri Apr 6, 7:34 pm)

Re: coding style for long conditions, Junio C Hamano, (Sat Apr 7, 4:01 am)

Re: coding style for long conditions, David Brownell, (Mon Apr 9, 11:14 am)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Jan Engelhardt, (Fri Apr 6, 5:53 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Krzysztof Halasa, (Fri Apr 6, 8:16 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Stefan Richter, (Fri Apr 6, 5:46 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Randy Dunlap, (Fri Apr 6, 5:40 pm)

Re: coding style for long conditions, Roland Dreier, (Fri Apr 6, 5:38 pm)

Re: coding style for long conditions, Scott Preece, (Mon Apr 9, 11:45 am)

Re: coding style for long conditions, David Brownell, (Fri Apr 6, 6:05 pm)

Re: coding style for long conditions, Jan Engelhardt, (Fri Apr 6, 6:07 pm)

Re: coding style for long conditions, David Brownell, (Fri Apr 6, 6:43 pm)

Re: coding style for long conditions, Zan Lynx, (Fri Apr 6, 5:50 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., Jeremy Fitzhardinge, (Fri Apr 6, 5:37 pm)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90]..., David Brownell, (Fri Apr 6, 5:54 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Randy Dunlap, (Thu Apr 5, 2:29 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Dmitry Torokhov, (Wed Apr 4, 4:42 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, David Brownell, (Wed Apr 4, 3:13 pm)

Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!, Randy Dunlap, (Wed Apr 4, 3:22 pm)

[PATCH 26/90] ARM: OMAP: abstract debug card setup (smc, leds), Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 27/90] ARM: OMAP: Add minimal OMAP2430 support, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 28/90] ARM: OMAP: USB peripheral support on H4, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 28/90] ARM: OMAP: USB peripheral support on H4, Pavel Machek, (Fri Apr 6, 8:07 am)

Re: [PATCH 28/90] ARM: OMAP: USB peripheral support on H4, Tony Lindgren, (Mon Apr 9, 5:42 pm)

[PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Pavel Machek, (Fri Apr 6, 8:09 am)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Russell King, (Sun Apr 8, 8:07 am)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Pavel Machek, (Sun Apr 8, 8:12 am)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Russell King, (Sun Apr 8, 10:40 am)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Pavel Machek, (Mon Apr 9, 7:13 am)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Russell King, (Sun Apr 8, 9:58 am)

Re: [PATCH 29/90] ARM: OMAP: Palm Tungsten|T support, Dagfinn Ilmari , (Sun Apr 8, 8:31 am)

[PATCH 30/90] ARM: OMAP: Palm Zire71 minor fixes, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 31/90] ARM: OMAP: plat-omap changes for 2430 SDP, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 32/90] ARM: OMAP: Basic support for siemens sx1, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 33/90] ARM: OMAP: This patch enables I2C-2 support fo..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 34/90] ARM: OMAP: Set keypad sense delays for the Palms, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 35/90] ARM: OMAP: speed up gpio irq handling, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 36/90] ARM: OMAP: Fix typo in board-h4.h, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 37/90] ARM: OMAP: MPUIO wake updates, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 38/90] ARM: OMAP: Sync headers with linux-omap, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 39/90] ARM: OMAP: Sync core code with linux-omap, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 40/90] ARM: OMAP: Sync board specific files with linu..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 41/90] ARM: OMAP: Avoid updating system time for sub-..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 42/90] ARM: OMAP: Tabify mux.c, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 43/90] ARM: OMAP: TUSB EVM init, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 43/90] ARM: OMAP: TUSB EVM init, Randy Dunlap, (Wed Apr 4, 2:44 pm)

Re: [PATCH 43/90] ARM: OMAP: TUSB EVM init, Tony Lindgren, (Thu Apr 5, 10:42 am)

[PATCH 44/90] ARM: OMAP: Add mailbox support for IVA, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 45/90] ARM: OMAP: Update omap h2 defconfig, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 46/90] ARM: OMAP: Add omap osk defconfig, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 47/90] ARM: OMAP: Fix gpmc header, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 48/90] ARM: OMAP: I2C-1 init fix for 2430, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 49/90] ARM: OMAP: update board 2430 file for TWL PIH ..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 50/90] ARM: OMAP: board-sdp2430.c Remove unnecessary ..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 51/90] ARM: OMAP: osk+mistral backlight, power, board..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 51/90] ARM: OMAP: osk+mistral backlight, power, b..., Randy Dunlap, (Wed Apr 4, 3:12 pm)

Re: [PATCH 51/90] ARM: OMAP: osk+mistral backlight, power, b..., Tony Lindgren, (Thu Apr 5, 11:28 am)

[PATCH 52/90] ARM: OMAP: cleanup apollon board, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 53/90] ARM: OMAP: Fix warning in timer32k.c, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 53/90] ARM: OMAP: Fix warning in timer32k.c, Randy Dunlap, (Wed Apr 4, 3:14 pm)

Re: [PATCH 53/90] ARM: OMAP: Fix warning in timer32k.c, Tony Lindgren, (Thu Apr 5, 11:15 am)

[PATCH 54/90] ARM: OMAP: Update timer32k.c to compile, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 55/90] ARM: OMAP: H3 workqueue fixes, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 55/90] ARM: OMAP: H3 workqueue fixes, Tony Lindgren, (Thu Apr 5, 11:17 am)

[PATCH 56/90] ARM: OMAP: Make board-palmz71 compile again, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 56/90] ARM: OMAP: Make board-palmz71 compile again, Tony Lindgren, (Thu Apr 5, 11:17 am)

[PATCH 57/90] ARM: OMAP: omap camera builds again; Mistral i..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 58/90] ARM: OMAP: musb_hdrc: tusb dma patch, minor, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 59/90] ARM: OMAP: Mostly cosmetic to sync up with lin..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 60/90] ARM: OMAP: Merge gpmc changes from N800 tree, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 60/90] ARM: OMAP: Merge gpmc changes from N800 tree, Tony Lindgren, (Thu Apr 5, 10:43 am)

[PATCH 61/90] ARM: OMAP: Merge driver headers from N800 tree, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 62/90] ARM: OMAP: Merge board specific files from N80..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 62/90] ARM: OMAP: Merge board specific files from..., Randy Dunlap, (Wed Apr 4, 5:18 pm)

Re: [PATCH 62/90] ARM: OMAP: Merge board specific files from..., Tony Lindgren, (Thu Apr 5, 3:48 pm)

[PATCH 63/90] ARM: OMAP: Merge PM code from N800 tree, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 63/90] ARM: OMAP: Merge PM code from N800 tree, Randy Dunlap, (Wed Apr 4, 5:51 pm)

Re: [PATCH 63/90] ARM: OMAP: Merge PM code from N800 tree, Tony Lindgren, (Thu Apr 5, 2:20 pm)

[PATCH 64/90] ARM: OMAP: Fix warning in pm.c, Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 64/90] ARM: OMAP: Fix warning in pm.c, Tony Lindgren, (Thu Apr 5, 11:18 am)

[PATCH 65/90] ARM: OMAP: Convert interrupt flags SA_* to IRQ..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 66/90] ARM: OMAP: Sync framebuffer headers with N800 ..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 67/90] ARM: OMAP: Replace mach-omap/omap2 with mach-o..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 68/90] ARM: OMAP: FB sync with N800 tree (support for..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 68/90] ARM: OMAP: FB sync with N800 tree (support..., Randy Dunlap, (Wed Apr 4, 4:52 pm)

Re: [PATCH 68/90] ARM: OMAP: FB sync with N800 tree (support..., Tony Lindgren, (Thu Apr 5, 11:39 am)

[PATCH 69/90] ARM: OMAP: add SoSSI clock, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 70/90] ARM: OMAP: add SoSSI clock (call propagate_rat..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 71/90] ARM: OMAP: add SoSSI clock (remove manual chec..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 72/90] ARM: OMAP: N770: add missing LCD, LCD controll..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 73/90] ARM: OMAP: Add onennand board specific support..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

Re: [PATCH 73/90] ARM: OMAP: Add onennand board specific sup..., Randy Dunlap, (Wed Apr 4, 4:39 pm)

Re: [PATCH 73/90] ARM: OMAP: Add onennand board specific sup..., Tony Lindgren, (Thu Apr 5, 11:30 am)

[PATCH 74/90] ARM: OMAP: N800: Update board-specific audio s..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 75/90] ARM: OMAP: 243x: Add mappings for SDRC and SMS, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 76/90] ARM: OMAP: Device init for OMAP24xx Enhanced A..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 77/90] ARM: OMAP: Add apollon gpio keys using gpio-ke..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 78/90] ARM: OMAP: TSC2101: add platform init / regist..., Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 79/90] ARM: OMAP: fix H4 dependencies again, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 80/90] ARM: OMAP: partial LED fixes, Tony Lindgren, (Wed Apr 4, 2:05 pm)

[PATCH 81/90] ARM: OMAP: omap2/pm.c build fix, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 82/90] ARM: OMAP: restore CONFIG_GENERIC_TIME, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 83/90] ARM: OMAP: Fix GCC-reported compile time bug, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 84/90] ARM: OMAP: Update changed TSC2301 config names..., Tony Lindgren, (Wed Apr 4, 2:06 pm)

Re: [PATCH 84/90] ARM: OMAP: Update changed TSC2301 config n..., Jarkko Nikula, (Thu Apr 5, 2:10 am)

Re: [PATCH 84/90] ARM: OMAP: Update changed TSC2301 config n..., Tony Lindgren, (Thu Apr 5, 11:47 am)

[PATCH 85/90] ARM: OMAP: Fix PRCM base register usage for 243x, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 86/90] ARM: OMAP: fix OMAP1 dmtimer build warning, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 87/90] ARM: OMAP: fix OMAP1 mpuio suspend/resume oops, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 88/90] ARM: OMAP: OSK led fixes, Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 89/90] ARM: OMAP: Activate MPU retention code in omap..., Tony Lindgren, (Wed Apr 4, 2:06 pm)

[PATCH 90/90] ARM: OMAP: H2 lcd updates for SPI framework, Tony Lindgren, (Wed Apr 4, 2:06 pm)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Gabriel C	Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
git:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
David Miller	[GIT]: Networking
Thomas Jarosch	Re: TCP connection stalls under 2.6.24.7
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 3 users and 1022 guests online.

Online users

Syndicate