Re: init's children list is long and slows reaping children.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Friday, April 6, 2007 - 11:02 am

Oleg Nesterov <oleg@tv-sign.ru> writes:


Well I would prefer to iterate over 2 lists as opposed to N lists that
we have now.

The __ptrace_unlink issue sounds moderately valid although a ptraced
zombie is down right peculiar.


Actually this should be independent of the pdeath_signal issue.
As long as we record pdeath_signal per task_struct we can continue
to implement the existing semantics.

Although we really should fix pdeath_signal and push the patch to
-mm.  We only didn't do that because the original patch was a
bug fix for stable kernels, and we didn't have time to verify fixing
pdeath_signal would not break anything else.


Well it doesn't fix everything yet but it does fix the common case.
I wonder if it would make sense to have other lists as well.

Regardless of how this fixes scaling someone needs to dig in there load
up all the messy state in their head and clean up, simplify,
and optimize this mess.

We still have the stupid case where we can create unkillable
zombies from user space with a threaded init.

I think it is safe to say that this part of the code has reach the point
of fragility where it is hard to maintain.  A clear sign that it is time to
refactor something.

Eric
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Thu Apr 5, 7:15 pm)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 8:38 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:02 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:04 am)
Re: init's children list is long and slows reaping children., Christoph Hellwig, (Fri Apr 6, 11:05 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:30 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:56 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 12:39 pm)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Mon Apr 9, 1:00 pm)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Mon Apr 9, 5:48 pm)
Re: init's children list is long and slows reaping children., Alexey Dobriyan, (Mon Apr 9, 10:07 pm)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 7:51 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 8:00 am)
[PATCH] Only send pdeath_signal when getppid changes., Eric W. Biederman, (Tue Apr 10, 8:16 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 8:22 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 9:17 am)
Re: [PATCH] Only send pdeath_signal when getppid changes., Oleg Nesterov, (Tue Apr 10, 9:37 am)
Re: [PATCH] Only send pdeath_signal when getppid changes., Eric W. Biederman, (Tue Apr 10, 10:41 am)
Re: [PATCH] Only send pdeath_signal when getppid changes., Roland McGrath, (Tue Apr 10, 10:48 am)
Re: init's children list is long and slows reaping children., Davide Libenzi, (Tue Apr 10, 12:17 pm)
Re: [PATCH] Only send pdeath_signal when getppid changes., Albert Cahalan, (Tue Apr 10, 8:17 pm)
[patch] uninline remove/add_parent() APIs, Ingo Molnar, (Tue Apr 10, 11:20 pm)
Re: [patch] uninline remove/add_parent() APIs, Eric W. Biederman, (Wed Apr 11, 12:00 am)
Re: init's children list is long and slows reaping children., Eric W. Biederman, (Wed Apr 11, 1:17 pm)
Re: [patch] uninline remove/add_parent() APIs, Andrew Morton, (Wed Apr 11, 3:06 pm)
Re: [patch] uninline remove/add_parent() APIs, Eric W. Biederman, (Thu Apr 12, 3:45 am)
Re: [patch] uninline remove/add_parent() APIs, Roland McGrath, (Thu Apr 12, 3:50 pm)