Re: [PATCH 2/8] Make process freezer reentrant | KernelTrap

Re: [PATCH 2/8] Make process freezer reentrant

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Oleg Nesterov

Subject: Re: [PATCH 2/8] Make process freezer reentrant

Date: Thursday, April 5, 2007 - 2:53 am

On 04/02, Gautham R Shenoy wrote:
quoted text>
>  int freeze_processes(unsigned long freeze_event)
>  {
>  	unsigned int nr_unfrozen;
> -
> +	int ret = 0;
> +	mutex_lock(&freezer_mutex);
> +	if (system_freeze_event_mask & freeze_event)
> +		goto done;

I am not sure this is correct. Suppose that system_freeze_event_mask == FE_SUSPEND,
now freeze_processes(FE_ALL) returns success. Shouldn't we return an error?

Oleg.

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Sun Apr 1, 10:34 pm)

[PATCH 1/8] Enhance process freezer interface for usage be ..., Gautham R Shenoy, (Sun Apr 1, 10:37 pm)

[PATCH 2/8] Make process freezer reentrant, Gautham R Shenoy, (Sun Apr 1, 10:37 pm)

[PATCH 3/8] Use process freezer for cpu-hotplug, Gautham R Shenoy, (Sun Apr 1, 10:38 pm)

[PATCH 4/8] Rip out lock_cpu_hotplug(), Gautham R Shenoy, (Sun Apr 1, 10:39 pm)

[PATCH 5/8] __cpu_up: use singlethreaded workqueue, Gautham R Shenoy, (Sun Apr 1, 10:40 pm)

[PATCH 6/8] Make non-singlethreaded workqueues freezeable ..., Gautham R Shenoy, (Sun Apr 1, 10:41 pm)

[PATCH 7/8] Clean up workqueue.c with respect to the freez ..., Gautham R Shenoy, (Sun Apr 1, 10:42 pm)

[PATCH 8/8] Make kernel threads freezeable for cpu-hotplug, Gautham R Shenoy, (Sun Apr 1, 10:42 pm)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Ingo Molnar, (Sun Apr 1, 11:16 pm)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Srivatsa Vaddagiri, (Mon Apr 2, 2:28 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Ingo Molnar, (Mon Apr 2, 4:18 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Mon Apr 2, 4:19 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Ingo Molnar, (Mon Apr 2, 4:27 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Srivatsa Vaddagiri, (Mon Apr 2, 5:42 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Pavel Machek, (Mon Apr 2, 6:22 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Pavel Machek, (Mon Apr 2, 6:56 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Mon Apr 2, 7:16 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Ingo Molnar, (Mon Apr 2, 11:56 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Rafael J. Wysocki, (Mon Apr 2, 1:48 pm)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Pavel Machek, (Mon Apr 2, 1:51 pm)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Rafael J. Wysocki, (Mon Apr 2, 3:12 pm)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Gautham R Shenoy, (Tue Apr 3, 12:59 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Oleg Nesterov, (Tue Apr 3, 4:47 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Tue Apr 3, 5:01 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Srivatsa Vaddagiri, (Tue Apr 3, 5:56 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Srivatsa Vaddagiri, (Tue Apr 3, 6:59 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Tue Apr 3, 7:01 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Tue Apr 3, 7:15 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Oleg Nesterov, (Tue Apr 3, 8:03 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Srivatsa Vaddagiri, (Tue Apr 3, 10:18 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Rafael J. Wysocki, (Tue Apr 3, 12:34 pm)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Andrew Morton, (Tue Apr 3, 1:24 pm)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Srivatsa Vaddagiri, (Tue Apr 3, 8:15 pm)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Ingo Molnar, (Wed Apr 4, 3:04 am)

Re: utrace merge, Ingo Molnar, (Wed Apr 4, 3:06 am)

Re: utrace merge, Christoph Hellwig, (Wed Apr 4, 3:36 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Wed Apr 4, 3:41 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Ingo Molnar, (Wed Apr 4, 4:49 am)

Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2), Gautham R Shenoy, (Wed Apr 4, 5:24 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Oleg Nesterov, (Wed Apr 4, 8:28 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Srivatsa Vaddagiri, (Wed Apr 4, 10:49 am)

Re: utrace merge, Andrew Morton, (Wed Apr 4, 11:41 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Oleg Nesterov, (Thu Apr 5, 2:46 am)

Re: [PATCH 2/8] Make process freezer reentrant, Oleg Nesterov, (Thu Apr 5, 2:53 am)

Re: [PATCH 2/8] Make process freezer reentrant, Gautham R Shenoy, (Thu Apr 5, 3:19 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Oleg Nesterov, (Thu Apr 5, 3:53 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Gautham R Shenoy, (Thu Apr 5, 3:59 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Oleg Nesterov, (Thu Apr 5, 4:30 am)

Re: [PATCH 6/8] Make non-singlethreaded workqueues freezea ..., Oleg Nesterov, (Thu Apr 5, 4:57 am)

Re: [PATCH 5/8] __cpu_up: use singlethreaded workqueue, Oleg Nesterov, (Thu Apr 5, 5:08 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Gautham R Shenoy, (Thu Apr 5, 5:14 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Oleg Nesterov, (Thu Apr 5, 5:20 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Oleg Nesterov, (Thu Apr 5, 6:34 am)

Re: [PATCH 6/8] Make non-singlethreaded workqueues freezea ..., Andrew Morton, (Thu Apr 5, 1:06 pm)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Rafael J. Wysocki, (Fri Apr 6, 7:34 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Nathan Lynch, (Fri Apr 6, 10:27 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Ingo Molnar, (Fri Apr 6, 10:34 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Nathan Lynch, (Fri Apr 6, 10:47 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Nigel Cunningham, (Fri Apr 6, 3:20 pm)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Nigel Cunningham, (Fri Apr 6, 3:22 pm)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Rafael J. Wysocki, (Sat Apr 7, 2:33 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Nigel Cunningham, (Sat Apr 7, 2:47 am)

Re: [PATCH 1/8] Enhance process freezer interface for usag ..., Gautham R Shenoy, (Sun Apr 8, 8:04 pm)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Srivatsa Vaddagiri, (Wed Apr 11, 7:22 pm)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Gautham R Shenoy, (Thu Apr 12, 3:01 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Oleg Nesterov, (Thu Apr 12, 9:00 am)

Re: [PATCH 7/8] Clean up workqueue.c with respect to the f ..., Gautham R Shenoy, (Fri Apr 13, 2:46 am)

Re: [PATCH 3/8] Use process freezer for cpu-hotplug, Pavel Machek, (Sat Apr 14, 11:48 am)

Navigation

Popular discussions


linux-kernel:
Paul Turner	[tg_shares_up rewrite v2 11/11] sched: update tg->shares after cpu.shares write
Ingo Molnar	Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2)
Michal Nazarewicz	Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Eric W. Biederman	Re: init's children list is long and slows reaping children.
Jeffrey V. Merkey	Re: Versioning file system
git:
Matthieu Moy	Re: Bugs in Gitosis
Daniel Barkalow	Re: About git and the use of SHA-1
David Lang	Re: mingw, windows, crlf/lf, and git
Shawn O. Pearce	Re: Bugs in Gitosis
Junio C Hamano	Re: [PATCH 14/21] Convert ce_path_match() to use struct pathspec
linux-netdev:
David Miller	Re: [2.6.30-rc3] powerpc: compilation error of mace module
David Miller	Re: [PATCH] ipv6: fix display of local and remote sit endpoints
Cong Wang	Re: [PATCH] s2io: add dynamic LRO disable support
Tobacco New Year Promo
Eric Dumazet	Re: [PATCH] net: implement emergency route cache rebulds when gc_elasticity is exc...
git-commits-head:
Linux Kernel Mailing List	V4L/DVB: tm6000: add special usb request to quit i2c tuner transfer
Linux Kernel Mailing List	of/flattree: merge early_init_dt_scan_memory() common code
Linux Kernel Mailing List	b43: N-PHY: add some registers and structs definitions
Linux Kernel Mailing List	powerpc: Move /proc/ppc64 to /proc/powerpc and add symlink
Linux Kernel Mailing List	drivers/acpi: use kasprintf
openbsd-misc:
Ted Bullock	Re: Proliant DL380 G3 cannot get on network
Eric Furman	Re: Defending OpenBSD Performance
Damien Miller	Re: Patching a SSH 'Weakness'
Tony Abernethy	Re: The Atheros story in much fewer words
Nick Holland	Re: 1 out of 3 hunks failed--saving rejects to kerberosV/src/lib/krb5/crypto.c.rej

Colocation donated by:

Syndicate