On Wed, 4 Apr 2007 13:51:18 -0700 David Brownell wrote:
> On Wednesday 04 April 2007 1:06 pm, Jan Engelhardt wrote:

quoted text
> >

> > On Apr 4 2007 12:00, Randy Dunlap wrote:

> > >

> > >> +static int __init fpga_init(void)

> > >> +{

> > >> +	if (machine_is_omap_h4()

> > >> +			|| machine_is_omap_h3()

> > >> +			|| machine_is_omap_h2()

> > >> +			|| machine_is_omap_perseus2()

> > >> +			)

> > >

> > >Perhaps there is nothing in CodingStyle for if () continuation

> > >lines.  Looks like it is needed.  This is ETOOMUCHINDENTATION by

> > >at least one tab.  Should be more like:

> > >

> > >+	if (machine_is_omap_h4()

> > >+	    || machine_is_omap_h3()

> > >+	    || machine_is_omap_h2()

> > >+	    || machine_is_omap_perseus2())

> >

> > My stance, || goes at EOL, and final ) not standalone:

>

> You are still violating the "only TABs used for indent" rule.

Yes, but CodingStyle is a just set of guidelines and common practices.

It doesn't cover multi-line if () statements, which is the subject of

the current controvers^W discussion.
> > 	if (foo ||

quoted text
> > 	  bar ||

> > 	  baz ||

> > 	  etc)

> > 		do_something;

---

~Randy

*** Remember to use Documentation/SubmitChecklist when testing your code ***

-

unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please read the FAQ at  http://www.tux.org/lkml/