Re: [PATCH -mm] Allow selective freezing of the system for different events

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <ego@...>
Cc: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, Oleg Nesterov <oleg@...>, Pavel Machek <pavel@...>, Pekka Enberg <penberg@...>, LKML <linux-kernel@...>
Date: Sunday, April 29, 2007 - 1:51 pm

Hi,

Sorry for the delay.

On Saturday, 28 April 2007 03:34, Gautham R Shenoy wrote:

I, personally, would introduce

static inline void freezer_exempt_event(struct task_struct *p,
				  unsigned long freeze_event_mask)
{
	atomic_set_mask(freeze_event_mask, &p->freezer_flags);
}

and then

static inline void freezer_exempt(struct task_struct *p)
{
	freezer_exempt_event(p, FE_ALL);
}

The patch would be shorter. ;-)

[In that case I'd probably rename freezer_should_exempt() to
freezer_should_exempt_event(), for symmetry.]


I would do

	return !(process_frozen_event_mask(p) & ~current_freezer_event);


The BUG_ON() is still valid if tasks are already frozen for this event.


Hmm, I wouldn't use the WARN_ON() here.  There's nothing wrong in calling
this twice in a row as long as we do the sanity checking.  There's even one
case in which that may be convenient, actually.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -mm 0/2] Separate freezer from PM code, Rafael J. Wysocki, (Fri Apr 27, 11:37 am)
[PATCH -mm 2/2] Introduce freezer flags, Rafael J. Wysocki, (Fri Apr 27, 11:40 am)
Re: [PATCH -mm] Allow selective freezing of the system for d..., Rafael J. Wysocki, (Sun Apr 29, 1:51 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Gautham R Shenoy, (Fri Apr 27, 5:40 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Rafael J. Wysocki, (Fri Apr 27, 5:49 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Rafael J. Wysocki, (Fri Apr 27, 6:09 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Pavel Machek, (Fri Apr 27, 6:07 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Rafael J. Wysocki, (Fri Apr 27, 6:56 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Pavel Machek, (Sat Apr 28, 3:07 am)
Re: [PATCH -mm 2/2] Introduce freezer flags, Gautham R Shenoy, (Fri Apr 27, 5:49 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Sam Ravnborg, (Fri Apr 27, 12:19 pm)
Re: [PATCH -mm 2/2] Introduce freezer flags, Gautham R Shenoy, (Fri Apr 27, 12:33 pm)
[PATCH -mm 1/2] Separate freezer from PM code, Rafael J. Wysocki, (Fri Apr 27, 11:38 am)
Re: [PATCH -mm 1/2] Separate freezer from PM code, Jeremy Fitzhardinge, (Fri Apr 27, 12:25 pm)
Re: [PATCH -mm 1/2] Separate freezer from PM code, Rafael J. Wysocki, (Fri Apr 27, 4:20 pm)
Re: [PATCH -mm 1/2] Separate freezer from PM code, Jeremy Fitzhardinge, (Fri Apr 27, 4:20 pm)
Re: [PATCH -mm 1/2] Separate freezer from PM code, Rafael J. Wysocki, (Fri Apr 27, 5:29 pm)
Re: [PATCH -mm 1/2] Separate freezer from PM code, Sam Ravnborg, (Sun Apr 29, 4:43 am)
Re: [PATCH -mm 1/2] Separate freezer from PM code, Sam Ravnborg, (Fri Apr 27, 12:15 pm)