On Sunday, 29 April 2007 01:45, Linus Torvalds wrote:
You are.
No, I don't. It's done by bmapping the file and writing directly to the
underlying blockdev. Otherwise we'd have corrupted filesystems after the
restore.
Swapfiles are handled this way anyway, so we just use the same code.
No, I didn't.
On one platform with a limited subset of device drivers.
I have no problems with the hibernation on my test boxes (six of them), except
for one network driver that doesn't bother to define a .suspend() callback.
There are problems with the suspend (s2ram), but they are _not_ related to the
freezing of kernel threads. Some of them are related to the other issue that
you have risen, which is that the same callbacks should not be used for the
suspend and hibernation, and which I think is absolutely valid. The remaining
ones are related to the fact that graphic card vendors don't care for us at
all.
It doesn't have that many problems as you are trying to suggest. At present,
the only problems with it happen if someone tries to "improve" it in the way
I did with the workqueues.
Anyway, the freezing of tasks, including kernel threads, is one of the few
things on which Pavel, Nigel and me completely agree that they should be done,
so perhaps you could accept that?
Greetings,
Rafael
-
